https://osmocom.org/https://osmocom.org/favicon.ico?16647414092017-06-13T13:48:49ZOpen Source Mobile CommunicationsOsmoSTP - Feature #2324: allow to bind to a configured IP addresshttps://osmocom.org/issues/2324?journal_id=42722017-06-13T13:48:49Zneelsnhofmeyr@sysmocom.de
<ul></ul><p>Code in question is libosmo-sccp/src/osmo_ss7_vty.c:</p>
<pre>
DEFUN(cs7_xua, cs7_xua_cmd,
"listen " XUA_VAR_STR " <0-65534>",
"Configure/Enable xUA Listener\n"
XUA_VAR_HELP_STR "SCTP Port number\n")
{
struct osmo_ss7_instance *inst = vty->index;
struct osmo_xua_server *xs;
enum osmo_ss7_asp_protocol proto = parse_asp_proto(argv[0]);
uint16_t port = atoi(argv[1]);
xs = osmo_ss7_xua_server_find(inst, proto, port);
if (!xs) {
xs = osmo_ss7_xua_server_create(inst, proto, port, NULL);
if (!xs)
return CMD_SUCCESS;
}
vty->node = L_CS7_XUA_NODE;
vty->index = xs;
return CMD_SUCCESS;
}
</pre>
<p>It's not so trivial to add an IP address here... possibly the easiest would be to allow another vty command that is identical except an IP address added at the end, and both call one common function to effect the server start?</p>
<p>Also interesting to note: the local_host=NULL is passed to osmo_ss7_xua_server_create() which directly does:</p>
<pre><code>LOGP(DLSS7, LOGL_INFO, "Creating %s Server %s:%u\n",<br /> get_value_string(osmo_ss7_asp_protocol_vals, proto), local_host, local_port);</code></pre>
<p>so this would log "(null)" as local bind address.</p> OsmoSTP - Feature #2324: allow to bind to a configured IP addresshttps://osmocom.org/issues/2324?journal_id=44832017-07-10T18:39:21Zlaforge
<ul><li><strong>Assignee</strong> set to <i>laforge</i></li></ul> OsmoSTP - Feature #2324: allow to bind to a configured IP addresshttps://osmocom.org/issues/2324?journal_id=46322017-07-19T16:27:12Zlaforge
<ul><li><strong>Assignee</strong> deleted (<del><i>laforge</i></del>)</li></ul><p>please keep in mind that the OsmoSTP VTY interface has been specifically designed to be compatible with how Cisco ITP is configured. So whatever propsals you make to introduce the functionality you need, try to not introduce avoidable incompatibility with that.</p> OsmoSTP - Feature #2324: allow to bind to a configured IP addresshttps://osmocom.org/issues/2324?journal_id=108622018-08-20T15:43:11Zneelsnhofmeyr@sysmocom.de
<ul></ul><p>IIUC there is</p>
<pre>
cs7 instance 0
listen m3ua 2905
local-ip 123.45.67.8
</pre> OsmoSTP - Feature #2324: allow to bind to a configured IP addresshttps://osmocom.org/issues/2324?journal_id=163602019-11-07T19:11:33Zpespin
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Feedback</i></li><li><strong>Assignee</strong> set to <i>neels</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>90</i></li></ul><p>That's already solved, "listen" node has "local-ip", and it's being used by osmo-stp in osmo-gsm-tester:<br /><pre>
listen m3ua 2905
accept-asp-connections dynamic-permitted
local-ip ${stp.ip_address.addr}
</pre></p>
<p>All the binding issues should have been fixed recently with the multi-home (multi-address bind and connect for SCTP) features in our libosmo-sccp stack (both for clients such as osmo-bsc/msc as well as server in osmo-stp).</p>
<p>I think we can close this ticket. Re-assigning to Neels to make sure I'm not missing something.</p> OsmoSTP - Feature #2324: allow to bind to a configured IP addresshttps://osmocom.org/issues/2324?journal_id=169062019-12-16T14:46:09Zneelsnhofmeyr@sysmocom.de
<ul><li><strong>Status</strong> changed from <i>Feedback</i> to <i>Resolved</i></li><li><strong>% Done</strong> changed from <i>90</i> to <i>100</i></li></ul>