Project

General

Profile

Actions

Feature #2528

closed

remove dead code after split from openbsc.git

Added by neels over 6 years ago. Updated almost 6 years ago.

Status:
Resolved
Priority:
Low
Assignee:
Category:
-
Target version:
-
Start date:
10/04/2017
Due date:
% Done:

80%

Resolution:
Spec Reference:

Description

osmo-msc.git works as is, but it may still have large amounts of dead code that came along from openbsc.git.
gsm_data_shared.* and struct gsm_network come to mind, and various utility functions may not be used in osmo-msc.
Also, the gsup_client and oap_client are duplicated between osmo-msc and osmo-sgsn.

Review all code, remove unused struct members, drop unused functions, eliminate code dup where it makes sense.

Also verify the build, dependencies, installed files.


Related issues

Related to OsmoBSC - Feature #2529: remove dead code after split from openbsc.gitRejectedneels10/04/2017

Actions
Related to OsmoSGSN - Feature #2530: remove dead code after split from openbsc.gitRejectedneels10/04/2017

Actions
Related to Cellular Network Infrastructure - Feature #2534: move gsup_client and oap_client code out of osmo-{msc,sgsn}.gitResolvedmsuraev10/04/2017

Actions
Actions #1

Updated by neels over 6 years ago

  • Related to Feature #2529: remove dead code after split from openbsc.git added
Actions #2

Updated by neels over 6 years ago

  • Description updated (diff)
Actions #3

Updated by neels over 6 years ago

  • Related to Feature #2530: remove dead code after split from openbsc.git added
Actions #4

Updated by neels over 6 years ago

  • Related to Feature #2534: move gsup_client and oap_client code out of osmo-{msc,sgsn}.git added
Actions #5

Updated by laforge over 6 years ago

  • Priority changed from High to Low
Actions #6

Updated by laforge about 6 years ago

  • % Done changed from 0 to 60
Actions #7

Updated by laforge about 6 years ago

  • Status changed from New to Feedback
  • % Done changed from 60 to 80
remote:   https://gerrit.osmocom.org/6411 gsm_data: remove unused gsm_subscriber_connection members
remote:   https://gerrit.osmocom.org/6412 remove bsc_api.h and all users - they're all dead code
remote:   https://gerrit.osmocom.org/6413 dead code removal
remote:   https://gerrit.osmocom.org/6414 remove unused dyn_ts_allow_tch_f VTY option
remote:   https://gerrit.osmocom.org/6415 remove unused VTY command "location updating reject cause" 
remote:   https://gerrit.osmocom.org/6416 remove unused "authorized-regexp" VTY command
remote:   https://gerrit.osmocom.org/6417 remove unused "auth policy" VTY command
Actions #8

Updated by neels almost 6 years ago

  • Status changed from Feedback to Resolved

Seems pointless to keep an issue on this. We will always continue to remove dead code when we see it.

Actions

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)