Feature #2574
closeddrop the concept of dummy packets from libosmo-mgcp
100%
Description
The legacy osmo-bsc_mgcp and/or (?) osmo-bsc-nat sent dummy RTP packets regularly to keep a NAT open.
In libosmo-mgcp, we are providing a solution for RTP and MGCP protocols, not specifically for a NAT solution.
Hence completely drop the dummy packets from libosmo-mgcp and osmo-mgw.
Applications that use libosmo-mgcp through a NAT and need to keep the NAT open shall put an own mechanism in place.
libosmo-legacy-mgcp and osmo-bsc_mgcp should still retain the dummy packet behavior though.
Updated by dexter over 6 years ago
As discussed today in the Team-Meeting, we will go for a switchable approach. The dummy packste will be an VTY option, so that it can be enabled if needed.
Updated by dexter over 6 years ago
- % Done changed from 0 to 100
I have now visited the code locations that control how dummy packets are send. It is not very obvious on the first look, but there is indeed already an option to disable the sending of dummy packets (no rtp keep-alive). This option is also the default. Before we always used rtp keep-alive once which only sends one dummy packet on reception of a CRCX or MDCX. I have now changed the code a bit to make it more explicit. I also added commonts that explain how it works.
Patch is up for review:
https://gerrit.osmocom.org/4617
Updated by neels over 6 years ago
dexter wrote:
there is indeed already an option to disable the sending of dummy packets (no rtp keep-alive).
ah, good to know! thanks.
