Bug #3009
closedpcuif_proto.h has mismatching versions across osmo-bsc.git, osmo-bts.git and osmo-pcu.git
100%
Description
For ericsson support, pcuif_proto.h was added to osmo-bsc.git for a BSC-co-located PCU (osmo-bsc b4999b60d48bcbb5aa575973d068e07ab672e095).
Later on, the osmo-bsc pcuif_proto.h version was bumped to 0x08 (osmo-bsc f14cb3535cf469632b5da63f35b31aa79fd0c5c3).
Presumably osmo-bsc and osmo-pcu must interoperate and have matching pcuif versions.
Furthermore, if osmo-pcu is bumped, it must interoperate with osmo-bts, so osmo-bts.git's pcuif_proto.h also needs bumping.
It seems that the ericsson changes have not completely propagated into the respective master branches.
Related issues
Updated by neels about 6 years ago
- Blocks Feature #3010: Implement 3-digit MNC with leading zeros added
Updated by neels about 6 years ago
even if the changes aren't ready for master, it would be good to at least straighten out the pcuif_proto.h versions to allow further additions without causing a huge mess.
(I need to add a flag for 3-digit MNC)
Updated by neels about 6 years ago
- Status changed from New to Resolved
- % Done changed from 0 to 100
this is actually resolved by:
https://gerrit.osmocom.org/6986
https://gerrit.osmocom.org/6984
https://gerrit.osmocom.org/6982
The patches are merged, and all of osmo-bts, osmo-pcu and osmo-bsc's pcuif_proto.h are identical
except for the PCU_SOCK_DEFAULT definition, which does not live in the osmo-bsc version of pcuif_proto.h
That could be something to argue about, but it's good enough for now.
