Project

General

Profile

Bug #3418

BTS TTCN-3 tests generate L2 frames with incorrect length

Added by stsp over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
High
Assignee:
Category:
-
Target version:
-
Start date:
07/25/2018
Due date:
% Done:

100%

Spec Reference:

Description

Since issue #3415 has been fixed, some BTS tests have started failing
because trxcon is now dropping frames generated by these tests.

The newly failing tests are:

BTS_Tests.TC_meas_res_sign_tchf
BTS_Tests.TC_meas_res_sign_tchh
BTS_Tests.TC_meas_res_sign_tchf
BTS_Tests.TC_meas_res_sign_tchh
BTS_Tests.TC_meas_res_sign_sdcch4
BTS_Tests.TC_meas_res_sign_sdcch8
BTS_Tests.TC_meas_res_sign_tchh_toa256
BTS_Tests.TC_rll_est_ind
BTS_Tests.TC_rll_rel_ind_DCCH_0
BTS_Tests.TC_rll_rel_ind_DCCH_3
BTS_Tests.TC_rll_rel_ind_ACCH_0
BTS_Tests.TC_rll_rel_ind_ACCH_3
BTS_Tests.TC_rll_unit_data_ind_DCCH
BTS_Tests.TC_chan_act_a51
BTS_Tests.TC_chan_act_a52
BTS_Tests.TC_chan_act_a53
BTS_Tests.TC_encr_cmd_a51
BTS_Tests.TC_encr_cmd_a52
BTS_Tests.TC_encr_cmd_a53


Related issues

Related to OsmocomBB - Bug #3415: heap overflow in trxcon / tch_fr_disassemble()Closed07/24/2018

Blocks OsmoBTS - Bug #3256: BTS_Tests.ttcn: Encryption + RLL tests not executed on Lm channels (TCH/H)Resolved05/10/2018

History

#1 Updated by stsp over 1 year ago

Proposed patch https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/10159 fixes:
TC_chan_act_a51
TC_chan_act_a52
TC_chan_act_a53

#2 Updated by stsp over 1 year ago

Proposed patch https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/10160 fixes
TC_rll_unit_data_ind_DCCH

#3 Updated by stsp over 1 year ago

  • Related to Bug #3415: heap overflow in trxcon / tch_fr_disassemble() added

#4 Updated by fixeria over 1 year ago

  • Related to Bug #3256: BTS_Tests.ttcn: Encryption + RLL tests not executed on Lm channels (TCH/H) added

#5 Updated by fixeria over 1 year ago

  • Status changed from New to In Progress
  • Priority changed from Normal to High
  • % Done changed from 0 to 30

I think it makes sense to implement automatic L2 frame padding (with 0x2b) in TTCN-3.

#6 Updated by fixeria over 1 year ago

  • Related to deleted (Bug #3256: BTS_Tests.ttcn: Encryption + RLL tests not executed on Lm channels (TCH/H))

#7 Updated by fixeria over 1 year ago

  • Blocks Bug #3256: BTS_Tests.ttcn: Encryption + RLL tests not executed on Lm channels (TCH/H) added

#8 Updated by fixeria over 1 year ago

  • Status changed from In Progress to Feedback
  • Assignee set to fixeria
  • % Done changed from 30 to 100

The fix has been submitted: https://gerrit.osmocom.org/10183/
It should make pass the remaining tests, which are failing for now...

#9 Updated by fixeria over 1 year ago

Regarding to the following test cases:

BTS_Tests.TC_meas_res_sign_tchf
BTS_Tests.TC_meas_res_sign_tchh
BTS_Tests.TC_meas_res_sign_tchf
BTS_Tests.TC_meas_res_sign_tchh
BTS_Tests.TC_meas_res_sign_sdcch4
BTS_Tests.TC_meas_res_sign_sdcch8
BTS_Tests.TC_meas_res_sign_tchh_toa256

there is a few interesting moments:

  • they are sending FAKE_RSSI command, which is not implemented in FakeTRX yet,
  • some of them related to Lm (TCH/H) channel, which is not supported by trxcon yet.

So, I am surprised that previously they have been executing successfully...

#10 Updated by fixeria over 1 year ago

  • Status changed from Feedback to Closed

Closing this issue, since the fixes has been merged and the tests are passing now.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)