OsmoSGSN fails --enable-werror on gcc >= 7
When I try to build osmo-sgsn with -Werror, I get
gprs_gmm_attach.c: In function ‘st_auth_on_enter’: gprs_gmm_attach.c:148:34: error: increment of a boolean expression [-Werror=bool-operation] ctx->gmm_att_req.auth_reattempt++; ^~ gprs_gmm_attach.c: In function ‘st_auth’: gprs_gmm_attach.c:163:39: error: comparison of constant ‘1’ with boolean expression is always true [-Werror=bool-compare] if (ctx->gmm_att_req.auth_reattempt <= 1) ^~
The big question now is : How did this ever pass build testing? But let's look at that in another issue...