https://osmocom.org/https://osmocom.org/favicon.ico?16647414092019-11-20T10:10:15ZOpen Source Mobile CommunicationsOsmoMSC - Bug #4273: OsmoMSC documentation clarificationhttps://osmocom.org/issues/4273?journal_id=164862019-11-20T10:10:15Zlaforge
<ul><li><strong>Subject</strong> changed from <i>documentation clarification</i> to <i>OsmoMSC documentation clarification</i></li></ul> OsmoMSC - Bug #4273: OsmoMSC documentation clarificationhttps://osmocom.org/issues/4273?journal_id=164872019-11-20T11:53:59Zfixeria
<ul></ul><p>As far as I can see from the code, both are the rate counters, and both indicate total amount of failed MT SMS delivery attempts. I have no idea what kind of 'thresholds' the user is asking about though.</p>
<p>Here is my proposal:</p>
<ul>
<li>{ "sms:rp_err_mem", "Failed MT SMS delivery attempts (no memory)." },</li>
<li>{ "sms:rp_err_other", "Failed MT SMS delivery attempts (other reason)." }.</li>
</ul>
<p>Let me know if this looks cleaner, so I will send a patch to Gerrit.</p>
<p>P.S. Looking at the other counters and their description, I noticed that we don't have a common format. Some lines start with "Count total amount", "Counts SMS" or "Number of". Such a mess! I believe we need to rephrase them too.</p> OsmoMSC - Bug #4273: OsmoMSC documentation clarificationhttps://osmocom.org/issues/4273?journal_id=164882019-11-20T12:05:02Zfixeria
<ul></ul><p>In general, a counter description should be written in a way to answer a single question: rate/count of <em>what</em>? So only the <em>what</em> should be in description. Otherwise it's redundant.</p>
<ul>
<li>BAD: [rate/count of] "Counts SMS which couldn't routed because no receiver found.",</li>
<li>BAD: [rate/count of] "Number of CIPHER MODE COMPLETE messages processed by BSSMAP layer.",</li>
<li>GOOD: [rate/count of] "Successful location updates.",</li>
<li>GOOD: [rate/count of] "Global SMS Deliver attempts.".</li>
</ul> OsmoMSC - Bug #4273: OsmoMSC documentation clarificationhttps://osmocom.org/issues/4273?journal_id=165052019-11-22T17:00:48Zfixeria
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li><li><strong>Assignee</strong> changed from <i>osmith</i> to <i>fixeria</i></li></ul> OsmoMSC - Bug #4273: OsmoMSC documentation clarificationhttps://osmocom.org/issues/4273?journal_id=165082019-11-22T18:29:21Zfixeria
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Feedback</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>90</i></li></ul><p>Please see: <a class="external" href="https://gerrit.osmocom.org/c/osmo-msc/+/16172">https://gerrit.osmocom.org/c/osmo-msc/+/16172</a> counters: clarify documentation for some MSC_CTR_SMS_* entries.</p> OsmoMSC - Bug #4273: OsmoMSC documentation clarificationhttps://osmocom.org/issues/4273?journal_id=166812019-12-02T09:11:01Zfixeria
<ul><li><strong>Status</strong> changed from <i>Feedback</i> to <i>Resolved</i></li><li><strong>% Done</strong> changed from <i>90</i> to <i>100</i></li></ul><p>Merged.</p>