https://osmocom.org/https://osmocom.org/favicon.ico?16647414092019-11-27T16:34:27ZOpen Source Mobile Communicationsosmo-sip-connector - Bug #4282: ttnc3-sip-test{,-latest} fail since 2019-11-24https://osmocom.org/issues/4282?journal_id=165362019-11-27T16:34:27Zosmith
<ul><li><strong>% Done</strong> changed from <i>10</i> to <i>20</i></li></ul><p>06b859ca314f53a902329ed95848dbafef1d4f87 is the first bad commit</p>
<pre>
commit 06b859ca314f53a902329ed95848dbafef1d4f87
Author: Neels Hofmeyr <neels@hofmeyr.de>
Date: Tue Nov 12 01:23:04 2019 +0100
msc: add sdp to MNCC
SDP is added to the MNCC protocol in osmo-msc
Ie16f0804c4d99760cd4a0c544d0889b6313eebb7.
This patch adds SDP to the ttcn3 MNCC messaging.
These changes still work with current osmo-msc master that doesn't send SDP /
ignores received SDP in MNCC.
Change-Id: Ic9568c8927507e161aadfad1a4d20aa896d8ae30
</pre> osmo-sip-connector - Bug #4282: ttnc3-sip-test{,-latest} fail since 2019-11-24https://osmocom.org/issues/4282?journal_id=165412019-11-28T11:27:37Zosmith
<ul></ul><p>This appears to be the problem, it does not happen when using the previous osmo-ttcn3-hacks.git commit.</p>
<p>osmo-sip-connector.log:<br /><pre>
mncc.c:936 Reconnected to /data/unix/mncc
mncc.c:961 MNCC rcvd message type: MNCC_SOCKET_HELLO
mncc.c:841 Got hello message version 5
mncc.c:961 MNCC rcvd message type: MNCC_SETUP_IND
mncc.c:477 gsm_mncc of wrong size 1860 vs. 836
</pre></p>
<p>So osmo-sip-connector can't handle additional data at the end of the MNCC packets, while OsmoMSC ignores them.</p> osmo-sip-connector - Bug #4282: ttnc3-sip-test{,-latest} fail since 2019-11-24https://osmocom.org/issues/4282?journal_id=165462019-11-28T12:48:59Zosmith
<ul><li><strong>% Done</strong> changed from <i>20</i> to <i>60</i></li></ul><p>I have the tests working locally again, after patching out the "wrong size" check in osmo-sip-connector (not sure if right approach, I'll discuss with Neels) and after fixing the tr_ templates, so they will match again:</p>
<pre>
13:15:27.516387 5 SIP_Tests.ttcn:219 Message enqueued on MNCC from SIP_Test-MNCC(3) @MNCC_Types.MNCC_PDU : {
msg_type := MNCC_RTP_CONNECT (517),
u := {
rtp := {
callref := 5001,
ip := 0,
rtp_port := 0,
payload_type := 0,
payload_msg_type := 0,
sdp := "0"
}
}
} id 3
13:15:27.516604 5 SIP_Tests.ttcn:221 Matching on port MNCC .u.rtp.sdp := "0" with "" unmatched: First message in the queue does not match the template:
</pre>
<p>WIP branch: osmith/fix-sipcon (osmo-ttcn3-hacks.git, osmo-sip-connector.git)</p> osmo-sip-connector - Bug #4282: ttnc3-sip-test{,-latest} fail since 2019-11-24https://osmocom.org/issues/4282?journal_id=165472019-11-28T14:14:45Zosmith
<ul><li><strong>% Done</strong> changed from <i>60</i> to <i>90</i></li></ul><p>Patches submitted:</p>
<p><a class="external" href="https://gerrit.osmocom.org/q/topic:sipcon-ttcn3-fix">https://gerrit.osmocom.org/q/topic:sipcon-ttcn3-fix</a></p>
<p>This will make it work with osmo-sip-connector from master. It doesn't seem worth it to also make it work with -latest, because then we would need to have another set of templates and a configuration switch to use them instead of the new ones.</p> osmo-sip-connector - Bug #4282: ttnc3-sip-test{,-latest} fail since 2019-11-24https://osmocom.org/issues/4282?journal_id=165632019-11-29T10:04:25Zosmith
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Resolved</i></li><li><strong>% Done</strong> changed from <i>90</i> to <i>100</i></li></ul> osmo-sip-connector - Bug #4282: ttnc3-sip-test{,-latest} fail since 2019-11-24https://osmocom.org/issues/4282?journal_id=167092019-12-03T11:11:25Zosmith
<ul></ul><p>Harald said in the meeting, that we won't make new releases of current master just to get the TTCN-3 tests working again. So I've prepared a patch release on top of the last release for osmo-sip-connector, that just adds the two line patch that makes the testsuite work with it again. It's currently in gerrit (same topic as other patches).</p>