https://osmocom.org/https://osmocom.org/favicon.ico?16647414092019-12-14T05:07:23ZOpen Source Mobile CommunicationsOsmoMSC - Bug #4324: SMS-over-GSUP: inconsistent SM-RP DA/OA codinghttps://osmocom.org/issues/4324?journal_id=168762019-12-14T05:07:23Zfixeria
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-1 priority-2 priority-default" href="/issues/2883">Bug #2883</a>: GSUP encoding of MSISDN is wrong</i> added</li></ul> OsmoMSC - Bug #4324: SMS-over-GSUP: inconsistent SM-RP DA/OA codinghttps://osmocom.org/issues/4324?journal_id=168832019-12-15T13:53:30Zfixeria
<ul><li><b>Checklist item</b> <input type='checkbox' class='checklist-checkbox' disabled> <i>OsmoMSC: fix MSISDN encoding for MO SMS</i> added</li><li><b>Checklist item</b> <input type='checkbox' class='checklist-checkbox' disabled> <i>Check SM-RP-DA/OA in the existing TTCN-3 test cases</i> added</li><li><b>Checklist item</b> <input type='checkbox' class='checklist-checkbox' disabled> <i>Update the Wireshark dissector to show ToN/NPI</i> added</li><li><b>Checklist item</b> <input type='checkbox' class='checklist-checkbox' disabled> <i>Update GSUP documentation</i> added</li><li><strong>Status</strong> changed from <i>New</i> to <i>Feedback</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>60</i></li></ul><p><a class="external" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16597">https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16597</a> MSC/BSC_ConnectionHandler: only keep SMSC address in SmsParametersRp<br /><a class="external" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16565">https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16565</a> library/GSUP_Types.ttcn: fix MSISDN / SMSC coding in SM-RP-OA/DA<br /><a class="external" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16566">https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16566</a> MSC_Tests.ttcn: fix: verify the contents of SM-RP-DA/OA for MO/MT SMS</p>
<p>This patch set reveals the problem of MSISDN coding during MO SMS forwarding.</p> OsmoMSC - Bug #4324: SMS-over-GSUP: inconsistent SM-RP DA/OA codinghttps://osmocom.org/issues/4324?journal_id=168972019-12-16T13:57:13Zneelsnhofmeyr@sysmocom.de
<ul></ul><p>This also relates to the OSMO_GSUP_MSISDN_IE. We should consider also making that able to transport the ToN/NPI.<br />But in this issue, you are talking only about the OA and DA, right?</p>
<p>I am wondering whether there is a backwards compatible way to change the coding.<br />Do ToN/NPI numbers start with some nibble or byte like 0xf that never appears in plain MSISDN?<br />I guess not...</p>
<p>I know, we can fairly easily adjust the SMS coding, because AFAIK no-one is using it yet (or is there someone)?<br />But I think it would be good to discuss binary compat in GSUP in general.</p>
<p>Added <a class="issue tracker-3 status-4 priority-2 priority-default" title="Support: GSUP binary compatibility: add GSUP protocol version IE? (Feedback)" href="https://osmocom.org/issues/4333">#4333</a> to discuss that.</p> OsmoMSC - Bug #4324: SMS-over-GSUP: inconsistent SM-RP DA/OA codinghttps://osmocom.org/issues/4324?journal_id=168982019-12-16T13:57:25Zneelsnhofmeyr@sysmocom.de
<ul><li><strong>Related to</strong> <i><a class="issue tracker-3 status-4 priority-2 priority-default" href="/issues/4333">Support #4333</a>: GSUP binary compatibility: add GSUP protocol version IE?</i> added</li></ul> OsmoMSC - Bug #4324: SMS-over-GSUP: inconsistent SM-RP DA/OA codinghttps://osmocom.org/issues/4324?journal_id=169302019-12-18T01:14:46Zfixeria
<ul></ul><p>Hi Neels!</p>
<blockquote>
<p>But in this issue, you are talking only about the OA and DA, right?</p>
</blockquote>
<p>Yep, and I also think the ToN/NPI header should be a part of 'generic' MSISDN IE. For SMS it's a bit more critical, because alphanumeric MSISDNs in general used quite often (e.g. 2FA services). I have never seen a call from alphanumeric MSISDNs though ;)</p>
<blockquote>
<p>Do ToN/NPI numbers start with some nibble or byte like 0xf that never appears in plain MSISDN?<br />I guess not...</p>
</blockquote>
<p>I also don't think so. See <a class="external" href="https://osmocom.org/issues/2883#note-3">https://osmocom.org/issues/2883#note-3</a> for all possible values.</p>
<blockquote>
<p>I am wondering whether there is a backwards compatible way to change the coding.<br />I know, we can fairly easily adjust the SMS coding, because AFAIK no-one is using it yet (or is there someone)?</p>
</blockquote>
<p>Yep, given that it's already broken. The only potential user I am aware of is <a class="user active" href="https://osmocom.org/users/288667">efistokl</a>, maybe he has any objections/ideas?</p>
<p>P.S. I wish I had proper TTCN-3 coverage for SM-RP-DA/OA back then, when SMS-over-GSUP was to be merged.</p> OsmoMSC - Bug #4324: SMS-over-GSUP: inconsistent SM-RP DA/OA codinghttps://osmocom.org/issues/4324?journal_id=169352019-12-19T08:02:28Zfixeria
<ul><li><b>Checklist item</b> <input type='checkbox' class='checklist-checkbox' checked disabled> <i>Update GSUP documentation</i> set to Done</li></ul><p><a class="external" href="https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/16654">https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/16654</a> chapters/gsup.adoc: further documentation for SM-RP-DA/OA IE coding</p> OsmoMSC - Bug #4324: SMS-over-GSUP: inconsistent SM-RP DA/OA codinghttps://osmocom.org/issues/4324?journal_id=169362019-12-19T08:36:56Zfixeria
<ul><li><b>Checklist item</b> <input type='checkbox' class='checklist-checkbox' checked disabled> <i>OsmoMSC: fix MSISDN encoding for MO SMS</i> set to Done</li><li><strong>% Done</strong> changed from <i>60</i> to <i>80</i></li></ul><p><a class="external" href="https://gerrit.osmocom.org/c/osmo-msc/+/16655">https://gerrit.osmocom.org/c/osmo-msc/+/16655</a> libmsc/gsm_04_11_gsup.c: fix SM-RP-OA encoding for MO SMS over GSUP</p> OsmoMSC - Bug #4324: SMS-over-GSUP: inconsistent SM-RP DA/OA codinghttps://osmocom.org/issues/4324?journal_id=169912020-01-05T21:48:10Zfixeria
<ul><li><b>Checklist item</b> <input type='checkbox' class='checklist-checkbox' checked disabled> <i>Check SM-RP-DA/OA in the existing TTCN-3 test cases</i> set to Done</li><li><strong>Status</strong> changed from <i>Feedback</i> to <i>Stalled</i></li><li><strong>Priority</strong> changed from <i>High</i> to <i>Low</i></li><li><strong>% Done</strong> changed from <i>80</i> to <i>90</i></li></ul><p>Updating Wireshark is the last thing to do.</p> OsmoMSC - Bug #4324: SMS-over-GSUP: inconsistent SM-RP DA/OA codinghttps://osmocom.org/issues/4324?journal_id=169922020-01-06T01:10:34Zfixeria
<ul><li><b>Checklist item</b> <input type='checkbox' class='checklist-checkbox' checked disabled> <i>Update the Wireshark dissector to show ToN/NPI</i> set to Done</li><li><strong>Status</strong> changed from <i>Stalled</i> to <i>Resolved</i></li><li><strong>% Done</strong> changed from <i>90</i> to <i>100</i></li></ul><p><a class="external" href="https://code.wireshark.org/review/35664">https://code.wireshark.org/review/35664</a> GSUP/SMS: also dissect ToN/NPI header in SM-RP-DA/OA</p>