Project

General

Profile

Actions

Bug #4668

closed

talloc report unreadable since vty logp command was introduced

Added by laforge almost 4 years ago. Updated almost 4 years ago.

Status:
Resolved
Priority:
High
Assignee:
Category:
libosmovty
Target version:
-
Start date:
07/15/2020
Due date:
% Done:

100%

Spec Reference:

Description

The output of 'show talloc-context application full' becomes thoroughly unreadable after Change-Id Ife5dc8999174c74e0d133729284fe526d6eaf8d9 was merged.

small excerpt to illustrate the problem:

    struct bsc_cbc_link            contains    846 bytes in   5 blocks (ref 0) 0x557fd3866470
      struct osmo_stream_cli         contains    738 bytes in   2 blocks (ref 0) 0x557fd38c4850
        127.0.0.1                      contains     10 bytes in   1 blocks (ref 0) 0x557fd3ac3a80
      127.0.0.1                      contains     10 bytes in   1 blocks (ref 0) 0x557fd3ac0c00
      127.0.0.1                      contains     10 bytes in   1 blocks (ref 0) 0x557fd38673b0
    struct osmo_nri_ranges         contains     16 bytes in   1 blocks (ref 0) 0x557fd38663f0
    struct llist_head              contains     16 bytes in   1 blocks (ref 0) 0x557fd3866370
  logging                        contains   5971 bytes in  11 blocks (ref 0) 0x557fd3865910
    Print a message on all log outputs; useful for placing markers in test logs
                                                                               A-bis Radio Link Layer (RLL)
                                                                                                           Layer3 Mobility Management (MM)
                                                                                                                                          Layer3 Radio Resource (RR)
                                                                                                                                                                    A-bis Radio Signalling Link (RSL)
                                                                                                                                                                                                     A-bis Network Management / O&M (NM/OML)
                                                                                                                                                                                                                                            Paging Subsystem
                                                                                                                                                                                                                                                            Radio Measurement Processing
                                                                                                                                                                                                                                                                                        Mobile Switching Center
                                                                                                                                                                                                                                                                                                               Hand-Over Process
 Hand-Over Decision
                   Reference Counting
                                     Control interface
                                                      BSC/NAT IMSI based filtering
                                                                                  PCU Interface
                                                                                               Local Call, Local Switch
                                                                                                                       lchan FSM
                                                                                                                                timeslot FSM
                                                                                                                                            assignment FSM
                                                                                                                                                          Cell Broadcast System
                                                                                                                                                                               Library-internal global log family
                                                                                                                                                                                                                 LAPD in libosmogsm
                                                                                                                                                                                                                                   A-bis Intput Subsystem
                                                                                                                                                                                                                                                         A-bis B-Subchannel TRAU Frame Multiplex
                                                                                                                                                                                                                                                                                                A-bis Input Driver for Signalling
  A-bis Input Driver for B-Channels (voice)
                                           Layer3 Short Message Service (SMS)
                                                                             Control Interface
                                                                                              GPRS GTP library
                                                                                                              Statistics messages and logging
                                                                                                                                             Generic Subscriber Update Protocol
                                                                                                                                                                               Osmocom Authentication Protocol
                                                                                                                                                                                                              libosmo-sigtran Signalling System 7
                                                                                                                                                                                                                                                 libosmo-sigtran SCCP Implementation
                                                                                                                                                                                                                                                                                    libosmo-sigtran SCCP User Adaptation
                                                                                                                                                                                                                                                                                                                        libosmo-sigtran MTP3 User Adaptation
                             libosmo-mgcp Media Gateway Control Protocol
                                                                        libosmo-netif Jitter Buffer
                                                                                                   Remote SIM protocol
                                                                                                                      Log debug messages and higher levels
                                                                                                                                                          Log informational messages and higher levels
                                                                                                                                                                                                      Log noticeable messages and higher levels
                                                                                                                                                                                                                                               Log error messages and higher levels
                                                                                                                                                                                                                                                                                   Log only fatal messages
                                                                                                                                                                                                                                                                                                          Arbitrary message to log on given category and log level

I don't know off my head what can be done, but I'm sure in the worst case we can call talloc_set_name_const() to associate a talloc chunk with a shorter, meaningful name, rather than the full string buffer of the object.

Actions #1

Updated by laforge almost 4 years ago

  • Category changed from libosmocore to libosmovty
  • Status changed from New to In Progress
  • % Done changed from 0 to 80
Actions #2

Updated by laforge almost 4 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 80 to 100

patch merged

Actions

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)