Project

General

Profile

Actions

Bug #4718

closed

ttcn3 test cases failures on master

Added by lynxis over 3 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
-
Start date:
08/18/2020
Due date:
% Done:

100%

Resolution:
Spec Reference:

Description

The ttcn3 test cases for master failing with

  <testcase classname='SIP_Tests' name='TC_mo_success_rel_gsm' time='30.025663'>
    <failure type='fail-verdict'>Tguard timeout
      SIP_Tests.ttcn:445 SIP_Tests control part
      SIP_Tests.ttcn:369 TC_mo_success_rel_gsm testcase
    </failure>
  </testcase>

https://jenkins.osmocom.org/jenkins/view/TTCN3/job/ttcn3-sip-test/896/console


Checklist

  • revert our change + test with recent FS sofia-sip
  • test again sofia-sip and revert sofia commit afb119aba813
  • write a github issue on freeswitch/sofia-sip by referencing jira bug FS-4102
Actions #1

Updated by lynxis over 3 years ago

  • Status changed from New to In Progress
Actions #2

Updated by lynxis over 3 years ago

sofia is violating the spec by adding a "Contact:" header to a BYE Request.
We "could" ignore it.

RFC3261: 20 Header fields, Table 2, Page 161.

Actions #3

Updated by lynxis over 3 years ago

  • Status changed from In Progress to Feedback
  • Assignee changed from lynxis to laforge
  • % Done changed from 0 to 50
Actions #4

Updated by lynxis over 3 years ago

The commit in sofia-sip which introduces our regression which lead to
https://gerrit.osmocom.org/c/osmo-sip-connector/+/19584

commit afb119aba813b2357203729ebdda555513ad56c2
Author: Anthony Minessale <anthm@freeswitch.org>
Date:   Thu Dec 22 16:13:44 2016 -0600    
FS-4102: [mod_sofia] invite to gateway without registration goes to another wrong host #resolve

FS-4102 (old freeswitch jira) describes a problem in FS, when using multiple gateways. FS sends a INVITE meant for gateway A, towards gateway B.

Actions #5

Updated by lynxis over 3 years ago

Actions #6

Updated by lynxis over 3 years ago

  • Status changed from Feedback to Stalled
  • Assignee changed from laforge to lynxis
  • % Done changed from 50 to 10

laforge on gerrit change https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19704

How did we end up changing this? I don't recall any changes to the BYE. Only INVITE was recently changed in > I5c35c5a4bad2fbe76c22ac6d7ee37c832e0ba246.

In general, I think we then should preferably fix the implementation rather than accepting our IUT to behave outside of the spec?

The invite headers seems to be used later in the invite, because it's added to the session handle. The bye is using all headers without any check.

I would abandon this commit and open a bug on the github page of sofia-sip.

Actions #7

Updated by lynxis over 3 years ago

  • Checklist item revert our change + test with recent FS sofia-sip added
  • Checklist item test again sofia-sip and revert sofia commit afb119aba813 added
  • Checklist item write a github issue on freeswitch/sofia-sip by referencing jira bug FS-4102 added
Actions #8

Updated by laforge over 3 years ago

On Fri, Aug 21, 2020 at 02:41:15PM +0000, lynxis [REDMINE] wrote:

I would abandon this commit and open a bug on the github page of sofia-sip.

works for me.

Actions #9

Updated by lynxis over 3 years ago

  • Checklist item revert our change + test with recent FS sofia-sip set to Done
  • Checklist item test again sofia-sip and revert sofia commit afb119aba813 set to Done
  • Checklist item write a github issue on freeswitch/sofia-sip by referencing jira bug FS-4102 set to Done
Actions #10

Updated by lynxis over 3 years ago

  • Status changed from Stalled to Resolved
  • % Done changed from 10 to 100
Actions

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)