Bug #5094
closedosmo-release.sh blindly assumes contrib/*.spec.in exists
100%
Description
by far not all osmocom projects have spec files in /contrib, yet osmo-release.sh nowadays blindly assumes their existance. Historyically, this used to work fine.
Any "spec" related activity should be conditional to such spec.in files actually existing.
Just tried to tag a new release of osmo-e1d and failed with this:
$ make REL=patch ALLOW_NO_LIBVERSION_CHANGE=1 release Releasing 0.2.0.1-4fea-dirty -> 0.2.1... OK: dependency specific versions in configure.ac and debian/control match grep: /space/home/laforge/projects/git/osmo-e1d/contrib/*.spec.in: No such file or directory grep: /space/home/laforge/projects/git/osmo-e1d/contrib/*.spec.in: No such file or directory grep: /space/home/laforge/projects/git/osmo-e1d/contrib/*.spec.in: No such file or directory grep: /space/home/laforge/projects/git/osmo-e1d/contrib/*.spec.in: No such file or directory grep: /space/home/laforge/projects/git/osmo-e1d/contrib/*.spec.in: No such file or directory OK: dependency specific versions in configure.ac and contrib/*.spec.in match OK: Found matching debian/lib*1.install for LIBVERSION=1:0:0 OK: Found 'Package: lib*1' in debian/control for LIBVERSION=1:0:0 grep: /space/home/laforge/projects/git/osmo-e1d/contrib/*.spec.in: No such file or directory ERROR: Found no matching '%files -n lib*1' in contrib/*.spec.in for LIBVERSION=1:0:0 make: *** [osmo-release.mk:9: release] Error 1
I've manually worked around by commenting out the parts of osmo-release.sh for now, but this needs to be fixed properly.
Updated by pespin about 3 years ago
- Status changed from New to Feedback
- % Done changed from 0 to 90
https://gerrit.osmocom.org/c/libosmocore/+/23505 Skip RPM checks if no *.spec.in available
Once merged, ticket can be closed.
Updated by laforge about 3 years ago
- Status changed from Feedback to Resolved
- % Done changed from 90 to 100
pespin wrote:
https://gerrit.osmocom.org/c/libosmocore/+/23505 Skip RPM checks if no *.spec.in available
Once merged, ticket can be closed.
If you had put "Closes:" in the ticket rather than "Related:" it would have been automatically closed. Doing that now.