Project

General

Profile

Gerrit » History » Version 90

osmith, 12/12/2018 11:36 AM

1 1 zecke
h1. Contributing using Gerrit
2
3 11 laforge
{{>toc}}
4
5 10 laforge
At [[OpenBSC:OsmoDevCon2016]] we discussed problems with our past contribution / patch submission process using mails on the mailing list as well as patchwork.  The result is that we want to give Gerrit a try for some time and see if it helps us to have a better process
6 1 zecke
7 10 laforge
Gerrit is a review tool that integrates nicely with git and ssh. You can find general information about Gerrit at https://www.gerritcodereview.com/
8 1 zecke
9 10 laforge
The advantages of Gerrit are:
10
* patch submission status is automatically tracked, also with several revisions for a patch set.
11
* patches are build-tested (and possibly even further tested) by jenkins before they are applied
12
* developers + maintainers can formally vote on a patch (developer: -1/0/+1, maintainer: -2/0/+2)
13
* once a patch has +2 score, it can be (automatically) merged into master
14
* patch sumissions not via git send-email but direcly from git
15
16
h2. Osmocom Subprojects using Gerrit
17
18 73 laforge
The majority of Osmocom sub-projects have chosen to use Gerrit for patch review.  In order to check if a given program uses Gerrit, please check the auto-generated list at https://gerrit.osmocom.org/#/admin/projects/
19 1 zecke
20 75 laforge
If the project is listed there, then it uses Gerrit.   If the project is not listed there, please send patches by e-mail to the respective project [[Mailing_Lists]] instead.
21 30 neels
22 1 zecke
h2. Configuring Gerrit/Account
23
24 54 neels
You will need to sign-up at https://gerrit.osmocom.org/login/. If you have an Osmocom Redmine account you can use https://osmocom.org/openid as OpenID provider.
25 1 zecke
26 68 neels
* first sign in on https://osmocom.org. Do this before logging in on gerrit (the redmine login process loses the gerrit login data and you'd have to do the same thing twice if not logged in on osmocom.org already).
27 55 neels
* go to https://gerrit.osmocom.org and click the "Sign in" link.
28 68 neels
* click the "Sign in with Osmocom":https://gerrit.osmocom.org/login/%23%2Fq%2Fstatus%3Aopen?id=https://osmocom.org/openid link (can be bookmarked). -- This is the same as entering https://osmocom.org/openid as OpenID provider and hitting the "Sign in" button.
29 61 neels
30
*careful:* enter 'https' to ensure that your openid credentials are passed on encryptedly.
31 68 neels
*pitfall:* if you're logged in on 'projects.osmocom.org' (including the 'projects.' part), you should also use the openid provider: https://projects.osmocom.org/openid; the 'projects.' part may be omitted, what's important is that redmine login and OpenID URLs match. Also, decide for one of those URLs once, because when picking a different OpenID URL next time, you will create a new user instead of logging in as yourself.
32 61 neels
*note:* gerrit will create a distinct user for each openid URL you pass. If you logged in successfully but your user seems to have lost permissions, you may have created an evil twin user: contact us on the mailing list so we can fix it in the user database.
33 54 neels
34
If you have no Osmocom redmine account, you can simply create one online at the "Register" link in the upper right corner.
35 10 laforge
Even without an existing or new redmine account, you should also be able to use any other OpenID provider to authenticate against gerrit (untested).
36
37
After the initial sign-up you will need to:
38 1 zecke
39
* Pick a username (can not be changed)
40
* Add your public ssh key(s)
41
* Add email addresses you intend to use as author/comitter
42 30 neels
43
If you would like to push private branches to the Gerrit repository, you also need to be added to the "known users" group.
44
Please send a short requesting email to openbsc@lists.osmocom.org.
45 1 zecke
46
h2. Setting up Gerrit for commits and pushing
47
48 33 neels
*Note:* it is easiest to work with gerrit when gerrit is the only remote in your git clone.
49
When you clone from git.osmocom.org and add the gerrit remote, git will have two remotes,
50 36 neels
so when you first checkout a branch you have to supply the remote explicitly (cumbersome).
51 34 neels
The gerrit repositories and git.osmocom.org are constantly synced, so it is sufficient
52
to clone from gerrit only.
53 33 neels
54
h3. Simplest: new clone
55
56 35 neels
* Create a new clone from gerrit
57
* Fetch the commit hook that adds Change-Id to each commit to uniquely identify a commit
58 42 neels
59 33 neels
<pre>
60
git clone ssh://$USERNAME@gerrit.osmocom.org:29418/$PROJECT.git
61
scp -P 29418 $USERNAME@gerrit.osmocom.org:hooks/commit-msg $PROJECT/.git/hooks/
62
</pre>
63
64
h3. SSH config
65
66
In '~/.ssh/config', add these lines:
67
<pre>
68 52 neels
Host go
69 33 neels
Hostname gerrit.osmocom.org
70
Port 29418
71
User $USERNAME
72
</pre>
73 52 neels
('go' means gerrit.osmocom, replace with your favorite shortcut name,
74 33 neels
replace '$USERNAME' with your user name as used on the gerrit website)
75
76
Then you can shorten above commands to
77 1 zecke
<pre>
78 52 neels
git clone ssh://go/$PROJECT.git
79 51 neels
cd $PROJECT
80
scp go:hooks/commit-msg .git/hooks/
81 33 neels
</pre>
82
83 46 neels
h3. Committer must match
84
85 47 neels
Your email address on gerrit and the email address git places in your
86 46 neels
commits must match, or you will get rejected with an error message like
87
"invalid commiter". You can add email addresses on the gerrit web UI.
88
89 33 neels
h3. Add gerrit to an existing clone
90
91 7 neels
* Add the remote to be able to fetch and push to gerrit
92
* Fetch the commit hook that adds Change-Id to each commit to uniquely identify a commit
93
94
<pre>
95
USERNAME=gerrit_user_name
96
PROJECT=$(basename $PWD)
97 1 zecke
git remote add gerrit ssh://$USERNAME@gerrit.osmocom.org:29418/$PROJECT.git
98
scp -P 29418 $USERNAME@gerrit.osmocom.org:hooks/commit-msg .git/hooks/
99 44 neels
</pre>
100
101 33 neels
h2. Push for review
102 1 zecke
103 81 neels
Prerequisites:
104
105
* your user on gerrit has an SSH public key
106
* your patch is committed in your local clone
107 82 neels
* the commit log message has a Change-Id (see 'commit-msg' hook above, and 'Tips and Tricks' below to add a Change-Id to a commit that lacks one.)
108 81 neels
109 77 neels
<pre>
110
git push $REMOTE $GITHASH:refs/for/$BRANCH/$TOPIC
111
</pre>
112
113
$REMOTE: from above instructions, that's either 'origin' (cloned from gerrit) or 'gerrit' (if you added a second remote).
114
$GITHASH: the committed patch to push, typically you're on your branch and simply push 'HEAD'.
115
$BRANCH: you will typically intend a patch to go to 'master'.
116
$TOPIC: an optional name you may choose.
117
118
For example, checkout the revision or branch that you want to submit for review,
119
i.e. the one where your patch or several patches are committed on top of the current master, then:
120 1 zecke
121 76 neels
If you cloned directly from gerrit:
122
123 1 zecke
<pre>
124 76 neels
git push origin HEAD:refs/for/master
125
</pre>
126
127
If you added 'gerrit' as a second remote to an existing clone:
128
129
<pre>
130 1 zecke
git push gerrit HEAD:refs/for/master
131 38 neels
</pre>
132 1 zecke
133 40 neels
You can optionally add a topic name with
134 1 zecke
135 40 neels
<pre>
136 76 neels
git push origin HEAD:refs/for/master/my_topic
137 38 neels
</pre>
138
139 57 neels
h2. Merge patch to master
140
141
A patch can be merged when it has CR+2 and V+1 votes, and if, in case of a
142
series of patches pushed from a branch, when its ancestor patches can also be
143
merged.
144
145
Sometimes the reviewer that gives CR+2 also hits the "Submit" button right away 
146
to merge the patch to master. Sometimes it is left up to the owner of the patch
147 59 neels
to decide when to hit "Submit" (who needs to be in the "Known Users" group).
148 57 neels
149
The V+1 vote means "build is verified" and is usually given by our jenkins
150 59 neels
gerrit builds: https://jenkins.osmocom.org/jenkins/view/Jenkins-Gerrit/
151 57 neels
152
The CR+2 vote means "code reviewed and ready for merge to master branch".
153
Accounts with the "Reviewer" role for a given project are allowed to give CR+2
154
votes. Others are allowed to give CR+1 (and CR-1). CR votes _don't_ add up.
155
156 67 neels
_Fixed by gerrit 2.12.6, see https://bugs.chromium.org/p/gerrit/issues/detail?id=4158:_
157
-Sometimes hitting the "Submit" button results in an error message saying
158 57 neels
"Change is New", which is a bug related to a private branch with the same
159 65 neels
patches being present. Can be fixed e.g. by an admin's manual push to master.-
160 1 zecke
161 84 neels
h2. Manage private branches
162 1 zecke
163 84 neels
Use a sub-directory with your name to group your own branches, please.
164 1 zecke
*Note* that you must be a member of the "known users" group, see above.
165
166 85 neels
To share / backup local branches to git.osmocom.org, without starting a code review process on gerrit.osmocom.org, just push them as usual to gerrit.
167 84 neels
168
* Note that the git repository must be cloned from the gerrit SSH URL -- all pushing goes to gerrit ("pushurl" as described below also works).
169
* All private branches are automatically synced to git.osmocom.org in a matter of minutes.
170 86 neels
* Private branches do not kick off patch sets for review, they are just branches. To kick off review for all patches on your branch, you'd use a 'refs/for/master' URL, as shown in the example below.
171 84 neels
172
The typical transcript for "Fred" developing feature "Kazoo" looks like this:
173
174 1 zecke
<pre>
175 84 neels
# Set up ~/.ssh/config so that 'go' points at gerrit.osmocom.org
176
git clone ssh://go/libosmocore
177
178
cd libosmocore
179
git checkout -b fred/kazoo   # create local branch
180
181
$EDITOR
182
git add kazoo.c
183
git commit -m "implement kazoo"
184
185
# just invoke 'git push' and git tells you how to create the branch once-off:
186 1 zecke
git push
187 84 neels
|fatal: The current branch asdf has no upstream branch.
188
|To push the current branch and set the remote as upstream, use
189
|
190
|    git push --set-upstream origin fred/kazoo
191 1 zecke
192 84 neels
git push --set-upstream origin fred/kazoo
193
# Now the branch exists on gerrit, very soon will also exist on git.osmocom.org
194
195
# Further tweaks
196
$EDITOR
197
git add kazoo.h
198
git commit --amend
199
200
# You are free to force-push private branches
201
git push -f
202
203
# origin/master has changed? Rebase onto the latest.
204
git fetch
205
git rebase -i origin/master
206
# resolve conflicts...
207
git push -f
208
209
# Feature is ready
210
git push origin HEAD:refs/for/master/kazoo
211 39 neels
</pre>
212 7 neels
213 48 ahuemer
h2. List changesets in gerrit
214 2 zecke
215 12 msuraev
<pre>
216 17 neels
git ls-remote gerrit changes/*
217 1 zecke
</pre>
218 80 neels
219
h1. Tips and Tricks
220
221
h2. A commit lacks a Change-Id
222
223
once you added the commit hook as above, just re-edit the commit log message, e.g. with
224
225
<pre>
226
git commit --amend
227
</pre>
228
229
or by
230
231
<pre>
232
git rebase -i
233
</pre>
234
235
and in the upcoming editor replacing 'pick' with 'r' in front of the commit to edit.
236 74 neels
237
No need to change the commit log if you don't want to, just exit the editor and the commit hook will add a Change-Id.
238 79 neels
239 87 msuraev
h2. Ignore WIP patches
240
241
Using following operators in "search" field of web UI allows to ignore Work-in-progress changes:
242
<pre>
243
status:open AND -is:wip
244
</pre>
245
246 79 neels
h2. Fetch fast from git.osmocom.org, push to gerrit
247
248 1 zecke
Gerrit has moved to a faster host, so this should no longer be necessary. Anyway...
249 74 neels
250
Adding a second remote forces you to often pass the remote on the command line ("origin").
251 79 neels
It is possible to have only one remote for cmdline convenience, with differing push and pull URLs:
252
253 74 neels
<pre>
254 1 zecke
git remote set-url origin git://git.osmocom.org/$PROJECT
255 74 neels
git remote set-url --push origin ssh://$USERNAME@gerrit.osmocom.org:29418/$PROJECT
256
</pre>
257 79 neels
258 74 neels
With above .ssh config you can also use the shorter ssh:// URL:
259
<pre>
260 79 neels
git remote set-url --push origin ssh://go/$PROJECT
261 74 neels
</pre>
262
263
The resulting .git/config in libosmocore would look something like:
264
<pre>
265
[remote "origin"]
266
        url = git://git.osmocom.org/libosmocore
267
        pushurl = ssh://go/libosmocore
268
        fetch = +refs/heads/*:refs/remotes/origin/*
269
</pre>
270 17 neels
271
Now you're fetching from git.osmocom.org, which is lightning fast, while pushing patches will still go to gerrit as usual.
272
273 45 neels
h2. Throw-away branch
274 13 neels
275 56 neels
If you need to adjust and re-submit patches, it may be handy to create a throw-away branch ("R D" in magit-gerrit in emacs for example),
276
make your changes/amendments and then send patch(es) back to gerrit while removing temporary branch automatically with "git review -f".
277
278
h2. Fetch a patch from gerrit
279
280
This script (I called it @P@) makes fetching a patch set from gerrit a breeze:
281
<pre>
282
#!/bin/sh
283
# fetch gerrit patch into new branch named like the patch number.
284
#
285
# Usage: go to a git clone and pass a patch number:
286
#
287
#   cd openbsc
288
#   P 973
289
# or
290
#   P 973/2
291
#
292
# Will create new local branches '973_4' (if 4 is the latest patch set)
293
# or '973_2', respectively.
294
295
patch="$1"
296
297
if [ -z "$patch" ]; then
298
  echo "Usage: P 1234[/5]"
299
  exit 1
300
fi
301
302
if [ -z "$(echo "$patch" | grep '/')" ]; then
303
  patch="/$patch/"
304
fi
305
306
if [ -z "$(echo "$patch" | grep '^/')" ]; then
307
  patch="/$patch"
308
fi
309
310
last_set="$(git ls-remote origin "changes/*" | grep "$patch" | sed 's#.*/\([^/]*\)$#\1 &#' | sort -n | tail -n 1)"
311
if [ -z "$last_set" ]; then
312
  echo "Not found: $patch"
313
  exit 1
314
fi
315
316
change_name="$(echo "$last_set" | sed 's/.*\(refs.*\)/\1/')"
317
branch_name="$(echo "$change_name" | sed 's#refs/changes/../\([0-9]*\)/\([0-9]*\)#\1_\2#')"
318
319
set -x
320
git fetch origin "$change_name"
321 25 neels
git co -b "$branch_name" FETCH_HEAD
322 13 neels
</pre>
323 1 zecke
324 58 neels
h2. Re-submit a Branch with Amended Commits
325
326 22 neels
On a feature branch, one typically has numerous commits that depend on their preceding commits.
327 58 neels
Often, some of the branch commits need to be amended for fixes. You can re-submit changes to
328
patches on your branch by pushing in the same way that you first submitted the branch.
329
330 29 neels
Note: if you modify the Change-Ids in the commit logs, your push would open entirely new
331 58 neels
review entries and you would have to abandon your previous submission. Comments on the first
332
submission are "lost" and you cannot diff between patch sets.
333 29 neels
334
(There used to be a bug in gerrit that required editing the first patch to be able to
335
re-submit a branch, but that's fixed.)
336 26 neels
337 1 zecke
338
339
h2. Re-submit Previously Abandoned Changes
340
341
You have to edit the Change-Ids, on a branch that would be every single commit log message.
342
343
<pre>
344
cd openbsc
345
git co my-branch
346
git rebase -i master
347
# replace all 'pick' with 'r' (or 'reword'), exit your editor
348
# git presents each commit log message for editing
349
</pre>
350
351 78 neels
h2. 502 Bad Gateway
352
353
When getting a "Bad Gateway" error message upon trying to login on gerrit, you probably just need to restart your web browser. The reason is not clear.
354
355
356
h2. Commit hook: Always put Change-Id at the bottom of the log message
357
358
The commit-msg hook places a Change-Id tag in the footer, often above other tags like 'Depends:' or 'Related:'. Since the Change-Id is an implementation detail for Gerrit, I personally prefer it always placed right at the bottom. This simple edit changes the commit-msg hook to add Change-Id at the bottom unconditionally:
359
360
<pre>
361
cd $PROJECT
362
sed -i 's/if (unprinted /if (0 \&\& unprinted /' .git/hooks/commit-msg
363
</pre>
364
365
The goal is to disable the condition in line 163 with an 'if (0...':
366
367
<pre>
368
                        if (0 && unprinted && match(tolower(footer[line]), changeIdAfter) != 1) {
369
                                unprinted = 0
370
                                print "Change-Id: I'"$id"'"
371
                        }
372 60 neels
</pre>
373 16 neels
374 13 neels
Then the Change-Id will be placed by line 170 instead.
375 16 neels
376
h1. Reasons for Particular Configuration
377
378 13 neels
h2. Rebase if necessary
379
380
There are different merge strategies that Gerrit performs to accept patches.
381
Each project can be configured to a specific merge strategy, but unfortunately you can't
382
decide on a strategy per patch submission.
383
384
It seems that the "Merge if Necessary" strategy is best supported, but it creates non-linear
385
history with numerous merge commits that are usually not at all necessary.
386
387
Instead, the "Cherry Pick" strategy puts each patch onto current master's HEAD to create
388 1 zecke
linear history. However, this will cause merge failures as soon as one patch depends on
389 13 neels
another submitted patch, as typical for a feature branch submission.
390
391 1 zecke
So we prefer the "Rebase if Necessary" strategy, which always tries to apply your patches to
392 13 neels
the current master HEAD, in sequence with the previous patches on the same branch.
393
However, some problems still remain, including some bugs in "Rebase if Necessary".
394
395 1 zecke
There's a problem with "Rebase if Necessary": If your branch sits at master's HEAD, Gerrit
396
refuses to accept the submission, because it thinks that no new changes are submitted.
397
This is a bug in Gerrit, which holger has fixed manually in our Gerrit installation:
398
399 16 neels
https://bugs.chromium.org/p/gerrit/issues/detail?id=4158
400 1 zecke
401 13 neels
402
h2. Private Branches: Create a new change for every commit...
403 16 neels
404 13 neels
Say you have an extensive feature in development, and you want to keep it on the
405
upstream git repository to a) keep it safe and b) collaborate with other devs on it.
406
So, of course, you have regularly pushed to refs/heads/yoyodyne/feature.
407
408
Since you have the gerrit commit hook installed, your feature branch already has
409
Change-Id tags in all commit log messages.
410
411
Now your feature is complete and you would like to submit it to master.
412 16 neels
Alas, Gerrit refuses to accept your patch submission for master, because it
413
knows the Change-Ids are also on a different branch.
414
415
Gerrit by default enforces that a Change-Id must be unique across all branches,
416
so that each submission for review is separate for each branch. Instead, we
417 13 neels
want to handle Change-Ids per-branch, so that you can have the same change
418 16 neels
submitted to different branches, as separate patch submissions, without having
419
to cosmetically adjust the Change-Id.
420 13 neels
421 20 neels
Solution: set the option 
422 14 neels
_Create a new change for every commit not in the target branch_ to _TRUE_
423
424
h2. Allow content merges
425
426
By default, gerrit compares patches only by the files' paths. If two paths are the same,
427
it immediately shows them as conflicts (path conflicts).
428
429 23 neels
In software development, a conflict usually means an actual content conflict, so if the
430 14 neels
edits are in two entirely separate places in the file, we don't consider this a conflict.
431
432 32 neels
By setting _Allow content merges_ to _TRUE_ in the git project config, we tell Gerrit to
433
perform text merges of the submitted patches and only complain about actual content
434
conflicts, in the usual software engineering sense.
435 72 laforge
436
h1. Admin
437
438
h2. Adding a new repository
439
440
* create the repository in the Gerrit Ui, inherit from "All-Projects"
441
* create an empty git repository using gitosis on git.osmcoom.org
442 88 osmith
* configure a jenkins build testing job for this project (see gerrit-verifications.yml in osmo-ci.git/jobs)
443 90 osmith
* configure "+3 voting":https://lists.osmocom.org/pipermail/openbsc/2018-November/012373.html by adding the attached attachment:rules.pl:
444 89 osmith
<pre>
445
$ git clone ssh://user@gerrit.osmocom.org/yournewrepo
446
$ cd yournewrepo
447
$ git fetch origin refs/meta/config:config
448
$ git checkout config
449
$ cp ~/Downloads/rules.pl .
450
$ git add rules.pl
451
$ git commit -m "rules.pl: merge at +3 (+2+1 / +1+1+1)"
452
$ git push origin HEAD:refs/meta/config
453
</pre>
454 72 laforge
455 32 neels
git replication to gerrit.osmocom.org is enabled automatically, nothing to be done here.  In case of doubt, try
456
@ssh -p 29418 gerrit.osmocom.org replication start --all --wait@
457
458
h2. Adding users to groups
459
460
Normally, the gerrit UI auto-completes a user name in the edit field. It has happened
461
though that an existing user is not auto-completed, as if it didn't exist. In that case,
462
find out the user ID (seven digit number like 1000123) and just enter that.
463
464
The user ID can be found on the user's "Settings" page, or in the database (s.b.).
465
466
h2. Querying the database directly
467
468
If your user has permission to access the database, you can place SQL queries using the
469 71 neels
'gerrit gsql' commands over ssh:
470
471 1 zecke
<pre>
472 53 neels
ssh go "gerrit gsql -c \"show tables\""
473
ssh go "gerrit gsql -c \"select full_name,account_id from accounts\""
474 1 zecke
</pre>
475
476 71 neels
(see ~/.ssh/config above for the 'go' shortcut)
477
478 62 neels
This seems to be the MySQL dialect.
479
480
The "...\"...\"" quoting allows including single-quotes in the SQL statements.
481
482
h2. Fix evil twin users
483
484 64 neels
If differing openid URLs have lead to evil twin users shadowing the same email address just without the permissions, you can fix it like this:
485 62 neels
486
<pre>
487
ssh go "gerrit gsql -c \"select * from account_external_ids where email_address like '%foo%'\""
488
# ACCOUNT_ID | EMAIL_ADDRESS   | PASSWORD | EXTERNAL_ID
489
# -----------+-----------------+----------+----------------------------------
490 64 neels
# 100004     | foo@example.com | NULL     | https://osmocom.org/openid/user/777
491 62 neels
# 100021     | foo@example.com | NULL     | https://projects.osmocom.org/openid/user/777
492 64 neels
493 62 neels
ssh go "gerrit gsql -c \"update account_external_ids set account_id = 100004 where email_address like '%foo%'\""
494
495
ssh go "gerrit gsql -c \"select * from account_external_ids where email_address like '%foo%'\""
496
# ACCOUNT_ID | EMAIL_ADDRESS   | PASSWORD | EXTERNAL_ID
497
# -----------+-----------------+----------+----------------------------------
498 1 zecke
# 100004     | foo@example.com | NULL     | https://osmocom.org/openid/user/777
499
# 100004     | foo@example.com | NULL     | https://projects.osmocom.org/openid/user/777
500
</pre>
Add picture from clipboard (Maximum size: 48.8 MB)