Project

General

Profile

Feature #1576

consider using hLayer2 as a pointer storage

Added by laforge almost 3 years ago. Updated almost 2 years ago.

Status:
New
Priority:
Low
Assignee:
Osmocom Developers
Category:
osmo-bts-sysmo
Target version:
-
Start date:
02/23/2016
Due date:
% Done:

0%

Spec Reference:

Description

This would speed up the l1if_hLayer_to_lchan lookup. Not sure if it's worth the extra risk.


Related issues

Related to OsmoBTS - Feature #1755: osmo-bts-sysmo L1: unify hLayer3 handlingNew2016-06-16

History

#1 Updated by laforge over 2 years ago

  • Assignee changed from laforge to neels

#2 Updated by laforge over 2 years ago

this is probably obsolete as we now use hLayer3?

#3 Updated by neels over 2 years ago

There seems to be a bit of a mix-up.

For example, in osmo-bts-sysmo/oml.c, this:

struct gsm_lchan *
l1if_hLayer_to_lchan(struct gsm_bts_trx *trx, uint32_t hLayer2)

is always called with an hLayer3 argument instead, e.g.:
lchan = l1if_hLayer_to_lchan(trx, cc->hLayer3);

However, this is not related to the addition of hLayer3 in https://gerrit.osmocom.org/264
and we should take another look at how much of this is going on in parallel (see #1755).

This issue mentions efficiency ("speed up"), which so far has not been part of my
considerations.

My conclusion is that we would need to spend some time to look at and discuss this
before rejecting this issue.

#4 Updated by neels over 2 years ago

  • Related to Feature #1755: osmo-bts-sysmo L1: unify hLayer3 handling added

#5 Updated by neels over 2 years ago

#6 Updated by neels over 2 years ago

#7 Updated by neels almost 2 years ago

  • Assignee changed from neels to Osmocom Developers

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)