Project

General

Profile

Feature #1658

make random 5-digit MSISDN generation optional

Added by laforge about 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
High
Assignee:
Category:
-
Target version:
-
Start date:
03/11/2016
Due date:
% Done:

100%

Spec Reference:

Description

currently, every subscriber is allocated a random 5-digit MSISDN when auto-created.

Allow for subscribers without MSISDN in the HLR, and make the behavior when creating subscribers configurable.

Possibly also make the number range for the random generation configurable.


Related issues

Related to OsmoNITB - Feature #1647: New authorization policy "matching IMSI"Closed03/11/2016

Associated revisions

Revision 9a7e25b9 (diff)
Added by max almost 5 years ago

Cleanup db test

Move copy-pasted code into separate function to make writing more tests
easier.

Related: OS#1658
Change-Id: I9e39af85718514dd0f081d41c234c9dda77c4b27
Reviewed-on: https://gerrit.osmocom.org/43
Tested-by: Jenkins Builder
Reviewed-by: Holger Freyther <>

Revision 98f0a380 (diff)
Added by max almost 5 years ago

Cleanup db test

Move copy-pasted code into separate function to make writing more tests
easier.

Related: OS#1658
Change-Id: I9e39af85718514dd0f081d41c234c9dda77c4b27
Reviewed-on: https://gerrit.osmocom.org/43
Tested-by: Jenkins Builder
Reviewed-by: Holger Freyther <>

Revision e21cf38d (diff)
Added by max almost 5 years ago

Make extending subscriber creation easier

  • rename variable controlling subscriber creation
  • use enum for subscriber creation policy
  • move check for subscriber creation policy into separate static
    function

Related: OS#1658, OS#1647
Change-Id: I3b10a9a764fd3a7bb96717a990e52caae16266da
Reviewed-on: https://gerrit.osmocom.org/42
Tested-by: Jenkins Builder
Reviewed-by: Holger Freyther <>

Revision 927d1a4d (diff)
Added by max almost 5 years ago

Make extending subscriber creation easier

  • rename variable controlling subscriber creation
  • use enum for subscriber creation policy
  • move check for subscriber creation policy into separate static
    function

Related: OS#1658, OS#1647
Change-Id: I3b10a9a764fd3a7bb96717a990e52caae16266da
Reviewed-on: https://gerrit.osmocom.org/42
Tested-by: Jenkins Builder
Reviewed-by: Holger Freyther <>

Revision 0fcd2e2f (diff)
Added by max almost 5 years ago

Make random extension range configurable

Previously if subscriber was automatically created it got assigned
random MSISDN number between 20000 and 49999. Make it configurable with
new vty command "subscriber-create-on-demand random" and expand vty
tests to check it.

Change-Id: I040a1d227b0c7a1601dc7c33eccb0007941408a6
Related: OS#1658

Revision 39115336 (diff)
Added by max almost 5 years ago

Make random extension range configurable

Previously if subscriber was automatically created it got assigned
random MSISDN number between 20000 and 49999. Make it configurable with
new vty command "subscriber-create-on-demand random" and expand vty
tests to check it.

Change-Id: I040a1d227b0c7a1601dc7c33eccb0007941408a6
Related: OS#1658

Revision e6052c4c (diff)
Added by max almost 5 years ago

Make random MSISDN assignment optional

Previously if subscriber was automatically created it got assigned
random MSISDN number. Make it optional (defaulting to previous behavior)
by adding following:

  • new optional no-extension argument for subscriber-create-on-demand vty
    command
  • db unit tests
  • vty test

Note: using the db made with new code might result in subscribers with
empty extension. Such subscribers cannot be deleted using old
code. Make sure not to mix db versions or manually fix it by editing
sqlite with external program.

Fixes: OS#1658
Change-Id: Ibbc2e88e4722b08854ebc631485f19ed56443cbb

Revision 5872641c (diff)
Added by max almost 5 years ago

Make random MSISDN assignment optional

Previously if subscriber was automatically created it got assigned
random MSISDN number. Make it optional (defaulting to previous behavior)
by adding following:

  • new optional no-extension argument for subscriber-create-on-demand vty
    command
  • db unit tests
  • vty test

Note: using the db made with new code might result in subscribers with
empty extension. Such subscribers cannot be deleted using old
code. Make sure not to mix db versions or manually fix it by editing
sqlite with external program.

Fixes: OS#1658
Change-Id: Ibbc2e88e4722b08854ebc631485f19ed56443cbb

History

#1 Updated by laforge about 5 years ago

  • Assignee set to msuraev

#2 Updated by laforge about 5 years ago

  • Priority changed from Normal to High

#3 Updated by msuraev about 5 years ago

  • Status changed from New to In Progress

#4 Updated by laforge almost 5 years ago

in-progress at 0% completion for 30 days? Please ensure ticket status reflects reality.

#5 Updated by msuraev almost 5 years ago

  • Related to Feature #1647: New authorization policy "matching IMSI" added

#6 Updated by msuraev almost 5 years ago

  • % Done changed from 0 to 50

The patch has been sent for review. Waiting for #1647 as it touches the same code parts before resubmitting it to gerrit.

#7 Updated by msuraev almost 5 years ago

  • % Done changed from 50 to 60

Under review in gerrit #201.

#8 Updated by msuraev almost 5 years ago

Also, gerrit #216.

#9 Updated by msuraev almost 5 years ago

  • Status changed from In Progress to Resolved
  • Assignee changed from msuraev to laforge
  • % Done changed from 60 to 100

Fix has been merged to master.

#10 Updated by laforge almost 5 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)