Project

General

Profile

Feature #1669

Feature #1668: NAT: Scalable configuration management

NAT: Add include command and load BSC configurations from another file

Added by zecke over 3 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Urgent
Assignee:
Category:
-
Target version:
-
Start date:
03/23/2016
Due date:
% Done:

0%

Resolution:
Spec Reference:

Description

Add a new VTY command to the NAT VTY to load a list of BSCs from a file. In practice the same VTY parsing logic can be used and it doesn't need to be enforced that this is limited to BSC parameters for now.

The goal is to specify something like:

nat
  bscs-config-file /etc/osmocom/bscs.cfg

History

#1 Updated by msuraev over 3 years ago

Do we have to preserve old config? Can "bsc 0" appear in both included file and the main config file?

#2 Updated by msuraev over 3 years ago

  • Status changed from New to In Progress

#3 Updated by msuraev over 3 years ago

  • Status changed from In Progress to Feedback

Proposed fix available in max/nat branch.

#5 Updated by zecke over 3 years ago

  • Does the bscs-config-file work with a relative path?
  • You most likely receive a compiler warning about config_write_bsc defined and not used
  • const char *conf = argv0; what is the reason for it? I mean argv0, argv0
  • Add "show bsc-config" (like show running-config) to list the BSCs and re-use the dead write_bsc config?

#6 Updated by msuraev over 3 years ago

zecke wrote:

  • Does the bscs-config-file work with a relative path?

Yes. The path is relative to the path from which osmo-bsc_nat binary is running.

  • You most likely receive a compiler warning about config_write_bsc defined and not used
  • const char *conf = argv0; what is the reason for it? I mean argv0, argv0

I think conf looks more descriptive than argv0.

  • Add "show bsc-config" (like show running-config) to list the BSCs and re-use the dead write_bsc config?

Done in separate commit.

#7 Updated by zecke over 3 years ago

On 29 Mar 2016, at 10:09, ms [REDMINE] <> wrote:

Issue #1669 has been updated by ms.

zecke wrote:

  • Does the bscs-config-file work with a relative path?

Yes. The path is relative to the path from which osmo-bsc_nat binary is running.

So loading the example config will not work right now? Please have a look at the python test/vty testrunner and such.

holger

#8 Updated by zecke over 3 years ago

relative paths are a stanrdard feature and need to be supported. To deal with VTY tests you could move the cfg file into a subdirectory.

#9 Updated by msuraev over 3 years ago

  • Assignee changed from msuraev to zecke

#10 Updated by zecke almost 3 years ago

  • Status changed from Feedback to Closed

Merged with 82f5ecde6a10c3c22980822a892a3fb5c69acf4f.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)