https://osmocom.org/https://osmocom.org/favicon.ico?16647414092016-05-02T22:59:01ZOpen Source Mobile Communicationsosmo-sip-connector - Feature #1682: osmo-sip-connector: Add better cause handlinghttps://osmocom.org/issues/1682?journal_id=13082016-05-02T22:59:01Zlaforge
<ul><li><strong>Category</strong> set to <i>osmo-sip-connector</i></li></ul> osmo-sip-connector - Feature #1682: osmo-sip-connector: Add better cause handlinghttps://osmocom.org/issues/1682?journal_id=32862017-03-08T13:50:29Zzecke
<ul><li><strong>Has duplicate</strong> <i><a class="issue tracker-2 status-5 priority-2 priority-default closed" href="/issues/1964">Feature #1964</a>: osmo-sip-connector: Communicate the failure cause from MNCC to SIP</i> added</li></ul> osmo-sip-connector - Feature #1682: osmo-sip-connector: Add better cause handlinghttps://osmocom.org/issues/1682?journal_id=32872017-03-08T13:50:59Zzecke
<ul></ul><p>From Keith:</p>
<p>In sip.c:238, we respond SIP_486_BUSY_HERE on call failures. <br />MNCC communicates to us useful information, as per isdn_cause struct defined in lcr's cause.c IIUC<br /><a class="external" href="https://github.com/osmobuntu/lcr/blob/master/cause.c">https://github.com/osmobuntu/lcr/blob/master/cause.c</a></p>
<p>It'd be nice to implement this. <br />I tried to get the gsm_mncc object into sip_release_call() to access the gsm_mncc->cause but came up against my deficient knowledge of C. :(</p>
<p>Happy to help otherwise with the copy pasting :)</p> osmo-sip-connector - Feature #1682: osmo-sip-connector: Add better cause handlinghttps://osmocom.org/issues/1682?journal_id=34092017-03-17T21:59:10Zlaforge
<ul><li><strong>Project</strong> changed from <i>OsmoNITB</i> to <i>osmo-sip-connector</i></li><li><strong>Category</strong> deleted (<del><i>osmo-sip-connector</i></del>)</li></ul> osmo-sip-connector - Feature #1682: osmo-sip-connector: Add better cause handlinghttps://osmocom.org/issues/1682?journal_id=34712017-03-29T18:43:01Zkeith
<ul></ul><p>How can I help to move this forward? <br />I get those unpleasant 3 ascending "failure" tones from the nokia regargless of hangup cause. for ex. on normal call termination. but you know that. If you can point me the right direction, I can try and contribute.</p> osmo-sip-connector - Feature #1682: osmo-sip-connector: Add better cause handlinghttps://osmocom.org/issues/1682?journal_id=34722017-03-29T21:36:39Zzecke
<ul></ul><blockquote>
<p>On 29. Mar 2017, at 20:43, keith [REDMINE] <<a class="email" href="mailto:redmine@lists.osmocom.org">redmine@lists.osmocom.org</a>> wrote:</p>
<p>Issue <a class="issue tracker-2 status-3 priority-2 priority-default closed child" title="Feature: osmo-sip-connector: Add better cause handling (Resolved)" href="https://osmocom.org/issues/1682">#1682</a> has been updated by keith.</p>
<p>How can I help to move this forward? <br />I get those unpleasant 3 ascending "failure" tones from the nokia regargless of hangup cause. for ex. on normal call termination. but you know that. If you can point me the right direction, I can try and contribute.</p>
</blockquote>
<p>Mostly how to map it and what SIP header to check for..</p>
<pre>
diff --git a/src/call.h b/src/call.h
index 7cb4932..9e70e2c 100644
--- a/src/call.h
+++ b/src/call.h
@@ -66,7 +66,7 @@ struct call_leg {
* Set by the call_leg implementation and will be called
* by the application to release the call.
*/
- void (*release_call)(struct call_leg *);
+ void (*release_call)(struct call_leg *, int q931_cause);
};
enum sip_cc_state {
</pre>
<p>I would start here and then look into the compilation failures to see which cause makes sense. E.g. for the mncc protocol we have the cause field which most likely is ITU Q931 encoded already (it could be something different but probably we can assume that this is not the case)</p>
<p>When is a realistic timeframe for you to look at it? I have some spots in my schedule where I could work on it with you.</p>
<p>holger</p> osmo-sip-connector - Feature #1682: osmo-sip-connector: Add better cause handlinghttps://osmocom.org/issues/1682?journal_id=85472018-03-27T13:44:01Zlaforge
<ul><li><strong>Assignee</strong> changed from <i>zecke</i> to <i>4368</i></li></ul> osmo-sip-connector - Feature #1682: osmo-sip-connector: Add better cause handlinghttps://osmocom.org/issues/1682?journal_id=110992018-09-01T20:39:26Zlaforge
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li><li><strong>Assignee</strong> changed from <i>4368</i> to <i>keith</i></li></ul> osmo-sip-connector - Feature #1682: osmo-sip-connector: Add better cause handlinghttps://osmocom.org/issues/1682?journal_id=111112018-09-02T12:43:13Zkeith
<ul><li><strong>% Done</strong> changed from <i>0</i> to <i>60</i></li></ul><p>Implemented now by<br /><a class="external" href="http://git.osmocom.org/osmo-sip-connector/commit/?id=503d8fdb64140061d7e64c64d0478de6acb2a7b7">http://git.osmocom.org/osmo-sip-connector/commit/?id=503d8fdb64140061d7e64c64d0478de6acb2a7b7</a><br />and<br /><a class="external" href="http://git.osmocom.org/osmo-sip-connector/commit/?id=008915ee41900c34ec0fd8df0c9f1d7c2cbdb3b2">http://git.osmocom.org/osmo-sip-connector/commit/?id=008915ee41900c34ec0fd8df0c9f1d7c2cbdb3b2</a></p>
<p>Cause mapping mainly follows this:</p>
<p><a class="external" href="https://github.com/fairwaves/lcr/blob/master/sip.cpp#L620">https://github.com/fairwaves/lcr/blob/master/sip.cpp#L620</a></p>
<p>which may have been based on this (probably should be anyway):<br /><a class="external" href="https://freeswitch.org/confluence/display/FREESWITCH/Hangup+Cause+Code+Table">https://freeswitch.org/confluence/display/FREESWITCH/Hangup+Cause+Code+Table</a></p> osmo-sip-connector - Feature #1682: osmo-sip-connector: Add better cause handlinghttps://osmocom.org/issues/1682?journal_id=118602018-10-02T15:39:06Zlaforge
<ul></ul> osmo-sip-connector - Feature #1682: osmo-sip-connector: Add better cause handlinghttps://osmocom.org/issues/1682?journal_id=155532019-08-07T09:20:16Zkeith
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Resolved</i></li></ul><p>I think this can be considered completed.</p>