Project

General

Profile

Bug #1800

AMR DTX: lchan->tch.last_sid is never populated with save_last_sid()

Added by laforge over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
High
Assignee:
Category:
-
Target version:
-
Start date:
08/20/2016
Due date:
% Done:

100%

Spec Reference:

Description

repeat_last_sid() uses lchan->tch.las_sid.fn and lchan->tch.las_sid.buf, which is initialized from save_last_sid().

The problem is: This function is never called. Hence there is no copy of the old sid frame available, and we have no knowledge when it was sent.


Related issues

Related to OsmoBTS - Bug #1799: AMR DTX: last_sid should operate on codec frame intervals (20ms), not gsm frame numberClosed08/20/2016

Related to OsmoBTS - Bug #1801: AMR DTX: downlink logic flawedClosed08/20/2016

Related to OsmoBTS - Bug #1803: osmo-bts-litecell15: AMR FR: some RTP buffers are never releasedClosed08/20/2016

Associated revisions

Revision 80473a11 (diff)
Added by max over 4 years ago

DTX: fix last SID saving

Previously SID was saved explicitly by each BTS model (lc15, sysmo)
instead of relying on generic function. Fix it by using generic function
and propagating necessary parameters for it.

Change-Id: Ie545212cce5ed2b3ea3228597f18a473f5e1deb4
Fixes: OS#1800

History

#1 Updated by laforge over 4 years ago

  • Related to Bug #1799: AMR DTX: last_sid should operate on codec frame intervals (20ms), not gsm frame number added

#2 Updated by laforge over 4 years ago

  • Related to Bug #1801: AMR DTX: downlink logic flawed added

#3 Updated by laforge over 4 years ago

#4 Updated by laforge over 4 years ago

  • Related to Bug #1803: osmo-bts-litecell15: AMR FR: some RTP buffers are never released added

#5 Updated by laforge over 4 years ago

  • Assignee changed from sysmocom to msuraev

#6 Updated by msuraev over 4 years ago

  • Subject changed from AMR DTX: lchan->tch.las_sid is never populated to AMR DTX: lchan->tch.last_sid is never populated
  • Status changed from New to In Progress

#7 Updated by msuraev over 4 years ago

  • Subject changed from AMR DTX: lchan->tch.last_sid is never populated to AMR DTX: lchan->tch.last_sid is never populated with save_last_sid()
  • % Done changed from 0 to 50

Fix sent for review as gerrit #845.

#8 Updated by msuraev over 4 years ago

  • Status changed from In Progress to Resolved
  • Assignee changed from msuraev to laforge
  • % Done changed from 50 to 100

Fix has been merged to master.

#9 Updated by laforge over 4 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)