Project

General

Profile

Actions

Bug #1800

closed

AMR DTX: lchan->tch.last_sid is never populated with save_last_sid()

Added by laforge over 7 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
High
Assignee:
Category:
-
Target version:
-
Start date:
08/20/2016
Due date:
% Done:

100%

Spec Reference:

Description

repeat_last_sid() uses lchan->tch.las_sid.fn and lchan->tch.las_sid.buf, which is initialized from save_last_sid().

The problem is: This function is never called. Hence there is no copy of the old sid frame available, and we have no knowledge when it was sent.


Related issues

Related to OsmoBTS - Bug #1799: AMR DTX: last_sid should operate on codec frame intervals (20ms), not gsm frame numberClosedlaforge08/20/2016

Actions
Related to OsmoBTS - Bug #1801: AMR DTX: downlink logic flawedClosedmsuraev08/20/2016

Actions
Related to OsmoBTS - Bug #1803: osmo-bts-litecell15: AMR FR: some RTP buffers are never releasedClosedlaforge08/20/2016

Actions
Actions #1

Updated by laforge over 7 years ago

  • Related to Bug #1799: AMR DTX: last_sid should operate on codec frame intervals (20ms), not gsm frame number added
Actions #2

Updated by laforge over 7 years ago

  • Related to Bug #1801: AMR DTX: downlink logic flawed added
Actions #3

Updated by laforge over 7 years ago

Actions #4

Updated by laforge over 7 years ago

  • Related to Bug #1803: osmo-bts-litecell15: AMR FR: some RTP buffers are never released added
Actions #5

Updated by laforge over 7 years ago

  • Assignee changed from 4368 to msuraev
Actions #6

Updated by msuraev over 7 years ago

  • Subject changed from AMR DTX: lchan->tch.las_sid is never populated to AMR DTX: lchan->tch.last_sid is never populated
  • Status changed from New to In Progress
Actions #7

Updated by msuraev over 7 years ago

  • Subject changed from AMR DTX: lchan->tch.last_sid is never populated to AMR DTX: lchan->tch.last_sid is never populated with save_last_sid()
  • % Done changed from 0 to 50

Fix sent for review as gerrit #845.

Actions #8

Updated by msuraev over 7 years ago

  • Status changed from In Progress to Resolved
  • Assignee changed from msuraev to laforge
  • % Done changed from 50 to 100

Fix has been merged to master.

Actions #9

Updated by laforge over 7 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)