Project

General

Profile

Feature #1848

osmo-bts-trx: code clean up / avoid global variables / osmo-trx communication code

Added by laforge over 4 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
osmo-bts-trx
Target version:
Start date:
11/18/2016
Due date:
% Done:

50%

Spec Reference:

Description

The osmo-bts-trx code for interfacing the osmo-trx could use some love. There are still global variables in there, and the mechanism on how to detect connection loss and setting configuration parameters seems a bit arcane.

Associated revisions

Revision cd1b08b1 (diff)
Added by laforge almost 4 years ago

TRX: Remove bogus extern global variable declarations

Those global variable declarations for non-existing variables were
introduced in 8a8d73a691c709403be4adbe8f2a7150b4d5998a, let's remove
them again. The source / destination IP address is a parameter of the
phy_link, and not a global variable.

Related: OS#1848
Change-Id: I94b5f934fc3bd00b0467d90029d3053b16594186

Revision aa119974 (diff)
Added by max over 3 years ago

osmo-bts-trx: remove global variables from loops

  • move TA related globals into phy_link
  • move power loop related globals into phy_link
  • prefix corresponding vty vars with osmotrx

Change-Id: I01d7c1abad67e51b886a4ecf2de072929d67da27
Related: OS#1848

History

#1 Updated by laforge over 4 years ago

  • Tracker changed from Bug to Feature

#2 Updated by laforge about 4 years ago

  • Assignee set to msuraev

#3 Updated by msuraev almost 4 years ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 20

Has been partially addressed by gerrit 3044 and 3045.

#4 Updated by msuraev almost 4 years ago

  • Status changed from In Progress to Stalled

#5 Updated by msuraev over 3 years ago

Gerrit 3601 has been sent for review - it removes remaining global variables.

#6 Updated by msuraev over 3 years ago

  • Status changed from Stalled to Feedback
  • Assignee changed from msuraev to laforge
  • % Done changed from 20 to 50

Gerrit 3601 has been merged, no more global variables in use.
What exactly shall I do about "the mechanism on how to detect connection loss and setting configuration parameters"?

#7 Updated by laforge over 3 years ago

  • Status changed from Feedback to Closed

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)