Project

General

Profile

Bug #1876

vty should complain about unknown pchan in config file

Added by neels almost 2 years ago. Updated 3 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Start date:
12/13/2016
Due date:
% Done:

0%

Spec Reference:

Description

If I misspell or freely invent PCHAN names in the osmo-nitb.cfg, osmo-nitb happily starts up
and all we get is a value error upon OML channel init.

The VTY should parse the pchan names and make sure only known channel names are used in the config file,
or reject startup with a parse error.

History

#1 Updated by neels almost 2 years ago

Example for a misspelled pchan:

[...]
   timeslot 2
    phys_chan_config  TCH/F_TCH/H_PDasdfasCH
    hopping enabled 0
   timeslot 3
    phys_chan_config  TCH/F_TCH/H_asdfasdafdsPDCH
    hopping enabled 0
[...]

#2 Updated by laforge 8 months ago

  • Project changed from OpenBSC to OsmoBSC

#3 Updated by laforge 4 months ago

  • Assignee set to stsp

#4 Updated by neels 4 months ago

side note: it makes sense to abort the program startup, but not to abort a running osmo-bsc from the interactive telnet VTY.
It is possible to find out whether the command came from an interactive VTY or from initial config file:

if (vty->type == VTY_FILE)
        OSMO_ASSERT(valid_string);

#6 Updated by stsp 3 months ago

  • Status changed from New to In Progress

#7 Updated by stsp 3 months ago

  • Status changed from In Progress to Resolved

Above patch has been merged.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)