Project

General

Profile

Bug #1905

Unit Test Suite failure in Osmo-PCU after recent commit done in libosmocore

Added by mrinal almost 3 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Target version:
-
Start date:
01/10/2017
Due date:
% Done:

100%

Spec Reference:

Description

In the latest PCU code ( commit: b3df58660f6e965799b18b5b87892a3272c4ccf1) Unit test case failure observed for "TBF" test suite.
On further analysis it is observed that due to recent commit on libosmocore( commit :addeaa39b172b4114bffbbfdd3dd09a029eb37b3) Test
case failure started.

Below are the snippet of Test Case failure in OSMO-PCU :

  1. ---------------------------------- ##
  2. osmo-pcu 0.2.875-b3df5 test suite. ##
  3. ---------------------------------- ##

Regression tests

1: rlcmac                                          ok
2: ts_alloc ok
3: tbf FAILED (testsuite.at:23)
4: bitcomp ok
5: edge ok
6: types ok
7: ms ok
8: llc ok
9: llist ok
10: codel ok
  1. ------------- ##
  2. Test results. ##
  3. ------------- ##
ERROR: All 10 tests were run,
1 failed unexpectedly.
  1. -------------------------- ##
  2. testsuite.log was created. ##
  3. -------------------------- ##

Please send `tests/testsuite.log' and all information you think might help:

To: <>
Subject: [osmo-pcu 0.2.875-b3df5] testsuite: 3 failed

You may investigate any problem if you feel able to do so, in which
case the test suite provides a good starting point. Its output may
be found below `tests/testsuite.dir'.

Makefile:1180: recipe for target 'check-local' failed
make1: * [check-local] Error 1
make1: Leaving directory '/home/mmishra/10_Jan_code/osmo-pcu/tests'
Makefile:1015: recipe for target 'check-am' failed
make: *
[check-am] Error 2

Below is the error log in TBF test suite:

=== start test_tbf_dl_llc_loss ===
Assert failed !check_element_exists(cnode, cmd->string) command.c:626
backtrace() returned 9 addresses
/usr/local/lib/libosmovty.so.3(install_element+0xce) [0x7fa03426914e]
/usr/local/lib/libosmovty.so.3(install_element_ve+0x11) [0x7fa034269581]
/usr/local/lib/libosmogb.so.4(gprs_ns_vty_init+0x17) [0x7fa0344840d7]
./TbfTest() [0x40e510]
./TbfTest() [0x404a46]
./TbfTest() [0x4029d1]
/lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf0) [0x7fa0332ad830]
./TbfTest() [0x4031e9]
Aborted (core dumped)

History

#1 Updated by laforge almost 3 years ago

Seems like gprs_bssgp_create_and_connect() is called multiple times,
and each time that calls gprs_ns_vty_init() which in turn registers
'show ns' command, despite already being registered before.

gprs_ns_vty_init() is a function to be called once at program start to
initialize the library, and not several times during runtime of a
program.
--
- Harald Welte <> http://laforge.gnumonks.org/ ============================================================================
"Privacy in residential applications is a desirable marketing option."
(ETSI EN 300 175-7 Ch. A6)

#2 Updated by laforge almost 3 years ago

this commit introduces a check that no two identical VTY commands are
registered at the same VTY node. If the PCU fails this check, the PCU
is likely broken in that regard. It is impossible to have two identical
VTY commands that actually work in practise.

#3 Updated by msuraev almost 3 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100

Fixed by c32bfd5824b99b9af14b66d17a58fdf9c3bddb45 in libosmocore.

#4 Updated by laforge almost 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)