Project

General

Profile

Actions

Feature #2232

closed

osmo-gsm-tester: Exceptions raised inside dbus signal callback not stopping the process

Added by pespin almost 7 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
-
Start date:
05/05/2017
Due date:
% Done:

100%

Spec Reference:

Description

If there's an (un)expected issue while doing some stuff in the context of a callback function called from a dbus signal coming from glib mainloop and we raise an Exception, we can see the Exception being printed on the stdout but the test is not stopping at that moment, it rather stops after the timeout in wait() at the end.

It would be nice for osmo-gsm-tester to stop everything no matter where the exception comes from. My guess is that the exception is being filtered consciously or unconsciously at some point inside pydbus or glib.

I'd advise modifying some signal callback code to print a backtrace and see the whole code path and then go look over the different frames where is the callback stopped and discarded.

Actions #1

Updated by pespin almost 7 years ago

  • Assignee set to 118
Actions #2

Updated by neels almost 7 years ago

  • % Done changed from 0 to 90

fixed by https://gerrit.osmocom.org/2486
(also related https://gerrit.osmocom.org/2485 but that alone did not fix the issue)

Actions #3

Updated by neels almost 7 years ago

  • Status changed from New to In Progress
  • Assignee changed from 118 to neels
Actions #4

Updated by neels almost 7 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 90 to 100

merged.

Actions #5

Updated by laforge over 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)