https://osmocom.org/https://osmocom.org/favicon.ico?16647414092017-10-27T10:04:48ZOpen Source Mobile Communicationslibosmo-sccp + libosmo-sigtran - Bug #2441: chopped-off pointcodeshttps://osmocom.org/issues/2441?journal_id=59472017-10-27T10:04:48Zlaforge
<ul><li><strong>Priority</strong> changed from <i>Normal</i> to <i>Urgent</i></li></ul> libosmo-sccp + libosmo-sigtran - Bug #2441: chopped-off pointcodeshttps://osmocom.org/issues/2441?journal_id=59502017-10-27T12:01:45Zlaforge
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>30</i></li></ul><p>it's likely a wrong mask in osmo_sccp_addr_encode(), where we only permit 0x3ff, i.e. 10 bit long point codes. Need to double-chech what's the actual length of point coes permitted in ITU SCCP and fix similar to the diff below:</p>
<pre>
@@ -237,7 +237,7 @@ int osmo_sccp_addr_encode(struct msgb *msg, const struct osmo_sccp_addr *in)
if (in->presence & OSMO_SCCP_ADDR_T_PC) {
sca->point_code_indicator = 1;
- msgb_put_u16le(msg, in->pc & 0x3ff);
+ msgb_put_u16le(msg, in->pc & 0x3fff);
}
if (in->presence & OSMO_SCCP_ADDR_T_SSN) {
</pre> libosmo-sccp + libosmo-sigtran - Bug #2441: chopped-off pointcodeshttps://osmocom.org/issues/2441?journal_id=59512017-10-27T13:00:20Zlaforge
<ul></ul><p>Proposed fix in <a class="external" href="https://gerrit.osmocom.org/4445">https://gerrit.osmocom.org/4445</a></p> libosmo-sccp + libosmo-sigtran - Bug #2441: chopped-off pointcodeshttps://osmocom.org/issues/2441?journal_id=59522017-10-27T15:49:28Zlaforge
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Resolved</i></li><li><strong>% Done</strong> changed from <i>30</i> to <i>100</i></li></ul><p>The fix has been merged.</p>
<p>I've meanwhile implemented some test cases that should help us avoiding any regressions about this in <a class="external" href="https://gerrit.osmocom.org/#/c/4449/">https://gerrit.osmocom.org/#/c/4449/</a></p> libosmo-sccp + libosmo-sigtran - Bug #2441: chopped-off pointcodeshttps://osmocom.org/issues/2441?journal_id=74452018-02-06T08:25:38Zlaforge
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Closed</i></li></ul>