release scripts shouldn't tag/sign at the same time as "make release"
It has been determined that it is impractical to have the tag in the repo at the same time we do a "make release". We cannot assume that the resulting commit will pass gerrit review/verification, and we cannot assume that no other commits are merged by gerrit first. Having a local tag in your repo that is not on the right commit hash will create all sorts of risks.
Updated by pespin over 4 years ago
- Status changed from New to Feedback
- Assignee changed from pespin to laforge
From my experience it's not a big issue, and I think we can close/reject this issue.
https://osmocom.org/projects/cellular-infrastructure/wiki/Make_a_new_release already explains how to re-create the tag. It is also explained how to undo the tag in case the commit needs to be re-created.
What I personally do:
- I create the new release commit+tag in my local pespin/releas and I submit it to gerrit
- When merged in gerrit, I git checkout master and I open gitk. If the tag shows up attached to the commit, everything's fine and no need to re-create the tag, I just git push origin <TAG>. Otherwise I follow the documentation in the wiki to re-create the tag.