https://osmocom.org/https://osmocom.org/favicon.ico?16647414092018-06-23T19:01:06ZOpen Source Mobile CommunicationsOsmoMGW - Bug #2660: osmo-mgw has no proper introspection via VTY + CTRLhttps://osmocom.org/issues/2660?journal_id=100332018-06-23T19:01:06Zlaforge
<ul><li><strong>Assignee</strong> changed from <i>4368</i> to <i>stsp</i></li></ul> OsmoMGW - Bug #2660: osmo-mgw has no proper introspection via VTY + CTRLhttps://osmocom.org/issues/2660?journal_id=101892018-07-03T08:15:20Zstsp
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li></ul> OsmoMGW - Bug #2660: osmo-mgw has no proper introspection via VTY + CTRLhttps://osmocom.org/issues/2660?journal_id=103472018-07-17T13:22:27Zstsp
<ul></ul><p>The 'show mgcp' VTY command already does most of what is being asked for in this issue.</p>
<p>I have added a VTY command which allows filtering the information shown by 'show mgcp' for a specific endpoint:<br /><a class="external" href="https://gerrit.osmocom.org/#/c/osmo-mgw/+/10022/">https://gerrit.osmocom.org/#/c/osmo-mgw/+/10022/</a><br />Such filtering could be quite useful for non-human VTY users, such as automated tests etc.</p>
<p>osmo-mgw does not seem to have a CTRL interface yet so nothing could be implemented there for this issue.</p> OsmoMGW - Bug #2660: osmo-mgw has no proper introspection via VTY + CTRLhttps://osmocom.org/issues/2660?journal_id=106312018-08-07T10:23:51Zstsp
<ul></ul><p>This is waiting for a response from Neels in code review. I am unsure if I need to take further action or if the patch is fine as proposed.</p> OsmoMGW - Bug #2660: osmo-mgw has no proper introspection via VTY + CTRLhttps://osmocom.org/issues/2660?journal_id=113782018-09-16T10:37:32Zlaforge
<ul></ul><p>ping? the patch has been meged. please keep this ticket updated (percent done, checklist items, ...) and take care of any missing bits.</p> OsmoMGW - Bug #2660: osmo-mgw has no proper introspection via VTY + CTRLhttps://osmocom.org/issues/2660?journal_id=115192018-09-20T16:44:47Zstsp
<ul></ul><p>Sorry. I forgot about updating this ticket after discussing this further with Neels.</p>
<p>I only recorded the result of our conversation in gerrit:<br /><a class="external" href="https://gerrit.osmocom.org/c/osmo-mgw/+/10022/#message-0ec211fc491919f3dadd03553d8e57f92f2d5bfc">https://gerrit.osmocom.org/c/osmo-mgw/+/10022/#message-0ec211fc491919f3dadd03553d8e57f92f2d5bfc</a></p>
<blockquote>
<p>Neels and I discussed this face-to-face today, and I've updated the patch set accordingly.<br />The main changes are:<br />There are now two new VTY commands, with and without a trunk number.<br />Endpoint names are printed without a 0x prefix.</p>
</blockquote>
<p>I'll update this ticket's checklist now.</p> OsmoMGW - Bug #2660: osmo-mgw has no proper introspection via VTY + CTRLhttps://osmocom.org/issues/2660?journal_id=115202018-09-20T16:44:56Zstsp
<ul><li><b>Checklist item</b> <input type='checkbox' class='checklist-checkbox' checked disabled> <i>proper "show mgcp endpoint" command</i> set to Done</li></ul> OsmoMGW - Bug #2660: osmo-mgw has no proper introspection via VTY + CTRLhttps://osmocom.org/issues/2660?journal_id=115212018-09-20T16:52:38Zstsp
<ul></ul><p>There are now two new commands:</p>
<ul>
<li>show mgcp endpoint NAME</li>
<li>show mgcp trunk <0-64> endpoint NAME</li>
</ul>
<p>Endpoint connection details (RTP stream IP addresses and ports) and be viewed with 'show mgcp stats'.</p>
<p>So the first two checklist items can be considered resolved.</p>
<p>It seems there remains some work to be done for the last checklist item (RTP and RTCP stats).</p> OsmoMGW - Bug #2660: osmo-mgw has no proper introspection via VTY + CTRLhttps://osmocom.org/issues/2660?journal_id=115222018-09-20T16:52:44Zstsp
<ul><li><b>Checklist item</b> <input type='checkbox' class='checklist-checkbox' checked disabled> <i>show endpoint connection details in vty</i> set to Done</li></ul> OsmoMGW - Bug #2660: osmo-mgw has no proper introspection via VTY + CTRLhttps://osmocom.org/issues/2660?journal_id=121022018-10-09T06:47:13Zstsp
<ul></ul><p>No further work has been done here yet.<br />I plan to discuss with Philip which RTP/TCP stats would be useful to collect and display.</p> OsmoMGW - Bug #2660: osmo-mgw has no proper introspection via VTY + CTRLhttps://osmocom.org/issues/2660?journal_id=123292018-10-23T13:08:36Zstsp
<ul></ul><p>I discussed this issue with <a class="user active" href="https://osmocom.org/users/15">dexter</a> today. There are some RTP statistics in OsmoMGW already, however they are lost when the connection is closed.</p>
<p>We put some thought into what global counters might be useful, and came up with the following list:</p>
<ul>
<li>mgw: RTP/RTCP connections (sockets) current and total</li>
<li>mgw: new RTP connections rejected</li>
<li>mgw: RTP connections aborted</li>
<li>mgw: bytes+packets transferred</li>
<li>mgw: RTP packets discarded (e.g. wrong port, wrong IP, wrong payload type, ...)</li>
</ul>
And also (not RTP-related):
<ul>
<li>mgcp: which codecs were used by how many connections</li>
</ul> OsmoMGW - Bug #2660: osmo-mgw has no proper introspection via VTY + CTRLhttps://osmocom.org/issues/2660?journal_id=123302018-10-23T13:10:13Zstsp
<ul></ul><p>Also related to this, I have submitted a patch which makes 'show rate-counters' on OsmoMGW's VTY more useful:<br /><a class="external" href="https://gerrit.osmocom.org/c/osmo-mgw/+/11439">https://gerrit.osmocom.org/c/osmo-mgw/+/11439</a><br />('show rate-counters' displays the per-connection stats mentioned above, which are discarded when the connection is closed)</p> OsmoMGW - Bug #2660: osmo-mgw has no proper introspection via VTY + CTRLhttps://osmocom.org/issues/2660?journal_id=123362018-10-23T17:20:07Zlaforge
<ul></ul><p>On Tue, Oct 23, 2018 at 01:08:37PM +0000, stsp [REDMINE] wrote:</p>
<blockquote>
<p>I discussed this issue with <a class="user active" href="https://osmocom.org/users/15">dexter</a> today. There are some RTP statistics in OsmoMGW already, however they are lost when the connection is closed.</p>
</blockquote>
<p>hopefully the "lost" here only refers to "lost from osmo_[rate]_ctr". Any RTP implementation<br />should send aggregated statistics to the peer using RTCP on teardown.</p>
<blockquote>
<ul>
<li>mgw: RTP/RTCP connections (sockets) current and total</li>
<li>mgw: new RTP connections rejected</li>
</ul>
</blockquote>
<p>what's a "rejected connection" in the context of RTP? As RTP is UDP, each packet<br />can get rejected?</p>
<blockquote>
<ul>
<li>mgw: RTP connections aborted</li>
</ul>
</blockquote>
<p>what is an "aborted connection" in the context of RTP?</p>
<blockquote>
<ul>
<li>mgw: bytes+packets transferred</li>
</ul>
</blockquote>
<p>I presume that means, separatee rx + tx counters for bytes + packets, like in SGSN.</p>
<blockquote>
And also (not RTP-related):
<ul>
<li>mgcp: which codecs were used by how many connections</li>
</ul>
</blockquote>
<p>great idea. I presume you're referring to the codecs negotiatated during MGCP CRCX/MDCX?<br />The MGCP/SDP protocol actually doesn't choose one codec, but choose a list of codecs, each<br />mapped to a given RTP payload type (PT). But sure, in such situations one simply bumps the counter<br />for each of the codecs in that list?</p> OsmoMGW - Bug #2660: osmo-mgw has no proper introspection via VTY + CTRLhttps://osmocom.org/issues/2660?journal_id=123882018-10-25T14:25:38Zstsp
<ul></ul><p>Sorry for not using the correct terms.</p>
<p>My comments should probably have said "MGCP connection".</p>
<p>And yes, "lost" just means that when an mgcp connection is freed, the rate counters maintained for that connection are freed as well.</p> OsmoMGW - Bug #2660: osmo-mgw has no proper introspection via VTY + CTRLhttps://osmocom.org/issues/2660?journal_id=123912018-10-25T16:45:14Zstsp
<ul></ul><p>This proposed patch adds statistics for MGCP CRCX command failures: <a class="external" href="https://gerrit.osmocom.org/c/osmo-mgw/+/11463">https://gerrit.osmocom.org/c/osmo-mgw/+/11463</a></p> OsmoMGW - Bug #2660: osmo-mgw has no proper introspection via VTY + CTRLhttps://osmocom.org/issues/2660?journal_id=124372018-10-29T16:37:48Zstsp
<ul></ul><p>More related patches have been proposed:</p>
<p>show RTP TX/RX stats in 'mgcp show stats' output<br /><a class="external" href="https://gerrit.osmocom.org/c/osmo-mgw/+/11494">https://gerrit.osmocom.org/c/osmo-mgw/+/11494</a></p>
<p>use local variable for rate counters in handle_create_con()<br /><a class="external" href="https://gerrit.osmocom.org/c/osmo-mgw/+/11495">https://gerrit.osmocom.org/c/osmo-mgw/+/11495</a></p>
<p>add more mgcp crxc error counters<br /><a class="external" href="https://gerrit.osmocom.org/c/osmo-mgw/+/11496">https://gerrit.osmocom.org/c/osmo-mgw/+/11496</a></p>
<p>add MDCX command statistics to osmo-mgw<br /><a class="external" href="https://gerrit.osmocom.org/c/osmo-mgw/+/11499">https://gerrit.osmocom.org/c/osmo-mgw/+/11499</a></p> OsmoMGW - Bug #2660: osmo-mgw has no proper introspection via VTY + CTRLhttps://osmocom.org/issues/2660?journal_id=124512018-10-30T10:53:32Zstsp
<ul></ul><p>Above patches have been merged.</p>
<p><a class="user active" href="https://osmocom.org/users/15">dexter</a> and I would still like to implement aggregation of counters maintained per RTP connection.<br />We'd introduce a global instance of these counters and aggregate stats from all connections there.<br />The reason is that per-connection counters are ephemeral; they can only be viewed on the VTY while the connection is live.</p> OsmoMGW - Bug #2660: osmo-mgw has no proper introspection via VTY + CTRLhttps://osmocom.org/issues/2660?journal_id=124562018-10-30T14:01:45Zstsp
<ul></ul><p>More proposed patches:</p>
<p>add aggregated rtp connection stats to osmo-mgw<br /><a class="external" href="https://gerrit.osmocom.org/c/osmo-mgw/+/11519">https://gerrit.osmocom.org/c/osmo-mgw/+/11519</a></p>
<p>add DLCX command statistics to osmo-mgw<br /><a class="external" href="https://gerrit.osmocom.org/c/osmo-mgw/+/11521">https://gerrit.osmocom.org/c/osmo-mgw/+/11521</a></p> OsmoMGW - Bug #2660: osmo-mgw has no proper introspection via VTY + CTRLhttps://osmocom.org/issues/2660?journal_id=128082018-12-03T13:10:13Zstsp
<ul><li><b>Checklist item</b> <input type='checkbox' class='checklist-checkbox' checked disabled> <i>show RTP and RTCP statistics / diagnostics information</i> set to Done</li></ul> OsmoMGW - Bug #2660: osmo-mgw has no proper introspection via VTY + CTRLhttps://osmocom.org/issues/2660?journal_id=128092018-12-03T13:10:45Zstsp
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Resolved</i></li></ul><p>Above patches have been merged as well.<br />I'm calling this issue done. If there's more to do here, please re-open.</p>