https://osmocom.org/https://osmocom.org/favicon.ico?16647414092018-08-08T11:24:22ZOpen Source Mobile Communicationslibosmocore - Feature #2740: shorten logging filenames when built outside of the source treehttps://osmocom.org/issues/2740?journal_id=106822018-08-08T11:24:22Zlaforge
<ul><li><strong>Assignee</strong> set to <i>neels</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul> libosmocore - Feature #2740: shorten logging filenames when built outside of the source treehttps://osmocom.org/issues/2740?journal_id=108172018-08-20T10:31:01Zneelsnhofmeyr@sysmocom.de
<ul><li><strong>% Done</strong> changed from <i>100</i> to <i>90</i></li></ul><p>(apologies, somehow this must've slipped by my issue sweeps for a long time.)</p>
<p>We have 'logging print file basename' for a long time now, so the shortened file name feature is pretty much resolved.</p>
<p>But still, we should not use <i>BASE_FILE</i>, which only coincidentally is the same file name that we expect to see. If we had a function that logs and that was defined in an included file, <i>BASE_FILE</i> would indicate the first file where the #include is, and not the file where the function is defined. <i>BASE_FILE</i> works because we don't ever include function definitions that log something, so <i>BASE_FILE</i> always coincides with <i>FILE</i> for our logging; but still <i>BASE_FILE</i> is semantically the wrong constant.</p>
<p><a class="external" href="https://gerrit.osmocom.org/#/c/libosmocore/+/10537">https://gerrit.osmocom.org/#/c/libosmocore/+/10537</a><br /><a class="external" href="https://gerrit.osmocom.org/#/c/osmo-bsc/+/10538">https://gerrit.osmocom.org/#/c/osmo-bsc/+/10538</a><br /><a class="external" href="https://gerrit.osmocom.org/#/c/osmo-msc/+/10539">https://gerrit.osmocom.org/#/c/osmo-msc/+/10539</a><br /><a class="external" href="https://gerrit.osmocom.org/#/c/osmo-sgsn/+/10540">https://gerrit.osmocom.org/#/c/osmo-sgsn/+/10540</a></p> libosmocore - Feature #2740: shorten logging filenames when built outside of the source treehttps://osmocom.org/issues/2740?journal_id=108212018-08-20T11:08:43Zneelsnhofmeyr@sysmocom.de
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li></ul> libosmocore - Feature #2740: shorten logging filenames when built outside of the source treehttps://osmocom.org/issues/2740?journal_id=108952018-08-20T22:14:27Zneelsnhofmeyr@sysmocom.de
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Resolved</i></li><li><strong>% Done</strong> changed from <i>90</i> to <i>100</i></li></ul><p>merged.</p>