Project

General

Profile

Feature #2819

migrate to python3

Added by msuraev almost 2 years ago. Updated about 21 hours ago.

Status:
In Progress
Priority:
High
Assignee:
Target version:
-
Start date:
01/07/2018
Due date:
% Done:

90%

Spec Reference:

Description

Python 2 is scheduked for complete deprecation by upstream in 2 years - https://pythonclock.org/
We should migrate all remaining python 2 code to python 3.

The code in osmo-python-tests iscompatible with both python 2 and 3 as of 2f266e0cec10e32db8781a8fb788b0432c33d6d9.

This allows to migrate code which uses it (ctrl and vty tests) to python 3. Once there're no more python 2 code depending on osmo-python-tests, we can drop support for python 2 from osmo-python-tests.


Checklist

  • osmo-python-tests
  • osmo-gsm-manuals
  • docker image used with jenkins scripts (osmo-ci)

History

#1 Updated by laforge 5 months ago

  • Priority changed from Normal to Low

#2 Updated by laforge 5 days ago

  • Assignee set to osmith
  • Priority changed from Low to High

I belive most of this has been done meanwhile, but maybe a good idea to check the status and update this ticket, including a check list with what's still missing [if any]?

#3 Updated by osmith 2 days ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 50

This should be straight forward, it seems that all scripts are already python3 compatible. So we only need to drop the python2 support.

However, I'm having problems with the debian packaging; override_dh_auto_install in debian/control does not appear to be working. When building the package, it still calls setup.py with "python" instead of "python3".

#4 Updated by osmith about 24 hours ago

  • Checklist item osmo-python-tests added
  • Checklist item osmo-gsm-manuals added
  • % Done changed from 50 to 60

Patch submitted for osmo-python-tests: https://gerrit.osmocom.org/c/python/osmo-python-tests/+/16500

osmo-gsm-manuals needs to be fixed too, it depends on python-pychart at least (instead of python3-pychart).

#5 Updated by osmith about 23 hours ago

osmo-gsm-manuals needs to be fixed too, it depends on python-pychart at least (instead of python3-pychart).

Turns out, that there is no python3-pychart package. Upstream of pychart seems to be dead, and nobody ported it to python3.

The good news is, that we are barely using it in the manuals. The only place I can find, where we use it, is in the osmux reference, the chart for "Evaluation: Expected traffic savings". Furthermore it seems that generating this chart was broken for some time - the pdf only shows the text "osmux-reference__8.png" where it should be.

So I will create an svg from the image once, and then drop the python2 dependency.

#6 Updated by pespin about 23 hours ago

Hi, with regards to osmux chart being broken see https://osmocom.org/issues/4193

#7 Updated by osmith about 21 hours ago

  • Checklist item docker image used with jenkins scripts (osmo-ci) added
  • % Done changed from 60 to 90

Hi, with regards to osmux chart being broken see https://osmocom.org/issues/4193

Thanks for the pointer! As side-effect, we can close this issue once the patches are merged.

Patches submitted:

https://gerrit.osmocom.org/q/topic:drop-py2

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)