Actions
Bug #2906
closedgsm_pchan2chan_nr asserts GSM_PCHAN_CCCH: lchan_nr == 0
Start date:
02/01/2018
Due date:
% Done:
100%
Spec Reference:
Description
see end of gsm_pchan2chan_nr in osmo-bts/src/common/gsm_data_shared.c. As of current master (40c05f07f49721e3ec89f6cd4a21a187a41336ef), an assert is commented because it was being triggered.
default: case GSM_PCHAN_CCCH: /* OSMO_ASSERT(lchan_nr == 0); * FIXME: On octphy and litecell, we hit above assertion (see * Max's comment at https://gerrit.osmocom.org/589 ); disabled * for BTS until this is clarified; remove the #ifdef when it * is fixed. */ #warning "fix caller that passes lchan_nr != 0" cbits = 0x10; break; }
Updated by pespin over 3 years ago
Related patch: https://gerrit.osmocom.org/c/openbsc/+/589
It may be related to the fact that GSM_PCHAN_NONE is not being handled in the function (which can happen if dyn.pchan_is is passed when it contains GSM_PCHAN_NONE on GSM_PCHAN_TCH_F_TCH_H_PDCH channels.
Updated by pespin over 2 years ago
- Status changed from New to Feedback
- % Done changed from 0 to 90
I submitted following patch:
https://gerrit.osmocom.org/c/osmo-bts/+/25825 gsm_pchan2chan_nr(): Properly assert if unexpected pchan is passed
Once merged Ithink this ticket can be closed.
Updated by pespin over 2 years ago
- Status changed from Feedback to Resolved
- % Done changed from 90 to 100
Merged, closing.
Actions