https://osmocom.org/https://osmocom.org/favicon.ico?16647414092018-02-27T21:58:15ZOpen Source Mobile CommunicationsOsmoPCU - Feature #3014: fix re-apply patches reverted by #3013, related: UL and DL packet assignment, and Timing Advancehttps://osmocom.org/issues/3014?journal_id=79112018-02-27T21:58:15Zneelsnhofmeyr@sysmocom.de
<ul></ul><p>here are pointers to the patches again:</p>
<p>reverted:</p>
<p><a class="issue tracker-1 status-3 priority-2 priority-default closed" title="Bug: regression: GPRS fatally unresponsive since commit 'Rewrite Packet Downlink Assignment' (Resolved)" href="https://osmocom.org/issues/3013#note-2">#3013#note-2</a></p>
<p><a class="external" href="https://gerrit.osmocom.org/#/q/status:open+project:osmo-pcu+branch:master+topic:fix_regression">https://gerrit.osmocom.org/#/q/status:open+project:osmo-pcu+branch:master+topic:fix_regression</a></p>
<p>=</p>
<p><a class="external" href="https://gerrit.osmocom.org/6976">https://gerrit.osmocom.org/6976</a> Revert "Use Timing Advance Index in UL assignments" <br /><a class="external" href="https://gerrit.osmocom.org/6977">https://gerrit.osmocom.org/6977</a> Revert "Rewrite Packet Uplink Assignment" <br /><a class="external" href="https://gerrit.osmocom.org/6978">https://gerrit.osmocom.org/6978</a> Revert "Rewrite Packet Downlink Assignment" <br /><a class="external" href="https://gerrit.osmocom.org/6979">https://gerrit.osmocom.org/6979</a> Revert "Rewrite EGPRS Packet Uplink Assignment"</p>
<p>original patches:</p>
<pre>
commit 6298fbb7b2f3639fde994633e33ba54a64a6ef9b
Author: Max <msuraev@sysmocom.de>
Date: Tue Jan 9 18:58:54 2018 +0100
Use Timing Advance Index in UL assignments
Write TAI (if available) when generating Rest Octets for UL
Assignment. This should not affect actual PCU behavior because TAI is
not yet supported by upper layers but we have to adjust corresponding
tests anyway.
Change-Id: I8b17be78a46c0bc17516b7c90f35aa4768010ae4
commit 93d947f5e8a30acc9250c124bf9d5bb6a8863526
Author: Max <msuraev@sysmocom.de>
Date: Tue Jan 9 18:54:29 2018 +0100
Rewrite Packet Uplink Assignment
Use bitvec_set_*() directly without external write pointer tracking to
simplify the code. This is part of IA Rest Octets (3GPP TS 44.018
§10.5.2.16) which is the last part of the message so it should not
interfere with the rest of encoding functions.
The tests are adjusted accordingly.
Change-Id: I44db2eeea7448ff67e688ae716487bc6dbfc96a3
Related: OS#1526
commit 896574e92bea09ed8d39688b6fdf504e84521746
Author: Max <msuraev@sysmocom.de>
Date: Tue Jan 9 18:45:41 2018 +0100
Rewrite Packet Downlink Assignment
Use bitvec_set_*() directly without external write pointer tracking to
simplify the code. This is part of IA Rest Octets (3GPP TS 44.018
§10.5.2.16) which is the last part of the message so it should not
interfere with the rest of encoding functions.
The tests are adjusted accordingly.
Change-Id: I52ec9b07413daabba8cd5f1fba5c7b3af6a33389
Related: OS#1526
commit 529ce885450946d85d1920fb3d1a994c3efe5849
Author: Max <msuraev@sysmocom.de>
Date: Tue Jan 9 13:15:05 2018 +0100
Rewrite EGPRS Packet Uplink Assignment
Use bitvec_set_*() directly without external write pointer tracking to
simplify the code. This is part of IA Rest Octets (3GPP TS 44.018
§10.5.2.16) which is the last part of the message so it should not
interfere with the rest of encoding functions.
Reusable fragments are split into static helpers.
Change-Id: I2139fb347b3290621bbc3f6a031f7f213d372e65
Related: OS#1526
</pre> OsmoPCU - Feature #3014: fix re-apply patches reverted by #3013, related: UL and DL packet assignment, and Timing Advancehttps://osmocom.org/issues/3014?journal_id=79122018-02-27T22:05:21Zneelsnhofmeyr@sysmocom.de
<ul></ul><p>quoting laforge on irc: [a good way] "to approach this is to use the TEMS phones and look at the protocol decodes of the messages before/after the related change"</p> OsmoPCU - Feature #3014: fix re-apply patches reverted by #3013, related: UL and DL packet assignment, and Timing Advancehttps://osmocom.org/issues/3014?journal_id=79132018-02-27T22:05:35Zneelsnhofmeyr@sysmocom.de
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-3 priority-2 priority-default closed" href="/issues/3013">Bug #3013</a>: regression: GPRS fatally unresponsive since commit 'Rewrite Packet Downlink Assignment'</i> added</li></ul> OsmoPCU - Feature #3014: fix re-apply patches reverted by #3013, related: UL and DL packet assignment, and Timing Advancehttps://osmocom.org/issues/3014?journal_id=80162018-03-03T21:45:26Zlaforge
<ul><li><strong>Assignee</strong> set to <i>4368</i></li></ul> OsmoPCU - Feature #3014: fix re-apply patches reverted by #3013, related: UL and DL packet assignment, and Timing Advancehttps://osmocom.org/issues/3014?journal_id=118702018-10-02T15:43:20Zlaforge
<ul></ul> OsmoPCU - Feature #3014: fix re-apply patches reverted by #3013, related: UL and DL packet assignment, and Timing Advancehttps://osmocom.org/issues/3014?journal_id=133612019-02-14T16:37:21Zmsuraev
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-3 priority-2 priority-default closed" href="/issues/1548">Bug #1548</a>: 11bit RACH support</i> added</li></ul> OsmoPCU - Feature #3014: fix re-apply patches reverted by #3013, related: UL and DL packet assignment, and Timing Advancehttps://osmocom.org/issues/3014?journal_id=135132019-03-07T17:18:33Zmsuraev
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li><li><strong>Assignee</strong> changed from <i>4368</i> to <i>msuraev</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>10</i></li></ul><p>The re-worked patch series is in gerrit, pending merge of MCS-related fixes.</p> OsmoPCU - Feature #3014: fix re-apply patches reverted by #3013, related: UL and DL packet assignment, and Timing Advancehttps://osmocom.org/issues/3014?journal_id=135142019-03-07T17:18:58Zmsuraev
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-3 priority-2 priority-default closed" href="/issues/3828">Bug #3828</a>: UL (M)CS update errors in TBF test</i> added</li></ul> OsmoPCU - Feature #3014: fix re-apply patches reverted by #3013, related: UL and DL packet assignment, and Timing Advancehttps://osmocom.org/issues/3014?journal_id=135162019-03-07T17:19:07Zmsuraev
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-3 priority-2 priority-default closed" href="/issues/3827">Bug #3827</a>: BSSGP counter group errors in TBF test</i> added</li></ul> OsmoPCU - Feature #3014: fix re-apply patches reverted by #3013, related: UL and DL packet assignment, and Timing Advancehttps://osmocom.org/issues/3014?journal_id=135782019-03-14T15:46:51Zmsuraev
<ul><li><strong>% Done</strong> changed from <i>10</i> to <i>50</i></li></ul><p>Gerrit 12956 and preceding patches should fix that.</p> OsmoPCU - Feature #3014: fix re-apply patches reverted by #3013, related: UL and DL packet assignment, and Timing Advancehttps://osmocom.org/issues/3014?journal_id=136372019-03-26T10:27:40Zmsuraev
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Stalled</i></li><li><strong>% Done</strong> changed from <i>50</i> to <i>60</i></li></ul><p>The current patch series is available in <a class="external" href="https://gerrit.osmocom.org/c/osmo-pcu/+/13057/">https://gerrit.osmocom.org/c/osmo-pcu/+/13057/</a> and it's dependencies. It's tested in gprs and egprs mode (with two-phase-access option to make sure we're not affected by instabilities described in <a class="issue tracker-1 status-4 priority-2 priority-default" title="Bug: PACCH on the wrong timeslot (Feedback)" href="https://osmocom.org/issues/1524">#1524</a>) and works fine.</p> OsmoPCU - Feature #3014: fix re-apply patches reverted by #3013, related: UL and DL packet assignment, and Timing Advancehttps://osmocom.org/issues/3014?journal_id=136392019-03-26T10:28:21Zmsuraev
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-4 priority-2 priority-default" href="/issues/1524">Bug #1524</a>: PACCH on the wrong timeslot</i> added</li></ul> OsmoPCU - Feature #3014: fix re-apply patches reverted by #3013, related: UL and DL packet assignment, and Timing Advancehttps://osmocom.org/issues/3014?journal_id=136662019-03-27T14:04:48Zmsuraev
<ul><li><strong>Status</strong> changed from <i>Stalled</i> to <i>Resolved</i></li><li><strong>% Done</strong> changed from <i>60</i> to <i>100</i></li></ul><p>Corresponding patches are merged into master.</p>