Project

General

Profile

Feature #3047

Test make distcheck and make maintainer-clean works for all projects in jenkins.sh

Added by pespin almost 2 years ago. Updated 5 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
-
Start date:
03/09/2018
Due date:
% Done:

100%

Spec Reference:

Description

Recently it was reported that osmo-trx make maintainer-clean was broken (already fixed). We should ideally test these during jenkins build, by adding the following bits to all contrib/jenkin.sh:

$MAKE distcheck
$MAKE maintainer-clean

History

#1 Updated by pespin almost 2 years ago

  • Description updated (diff)

#2 Updated by laforge 7 months ago

  • Assignee set to osmith

#3 Updated by osmith 5 months ago

  • Status changed from New to In Progress

#4 Updated by osmith 5 months ago

  • % Done changed from 0 to 50

Initial batch of patches submitted:
https://gerrit.osmocom.org/q/topic:make-maintainer-clean

For some repositories, the CI test is failing, which mostly means that "make maintainer-clean" is actually broken there. I'm looking into fixing those.

While I was at it, I have also prepared patches to add a jenkins.sh script to libosmo-dsp (right now, the autoreconf -fi, ./configure, make etc. commands are hardcoded in master-builds.yml). And another patch to enable gerrit-verifications for all repositories that were only enabled in master-builds.yml.

laforge, it seems that I lack permissions to push patches to gerrit for the following repositories. Can you give me the permissions, so I can submit all patches I have prepared?
  • libosmo-dsp
  • osmo-gmr
  • rtl-sdr

#5 Updated by laforge 5 months ago

osmith wrote:

laforge, it seems that I lack permissions to push patches to gerrit for the following repositories. Can you give me the permissions, so I can submit all patches I have prepared?
  • libosmo-dsp
  • osmo-gmr
  • rtl-sdr

those three projects are not written/maintained by sysmocom but are maintained by the respective developers tnt and @steve-m. Its up to the respective authors/maintainers to decide who should have comit access to those repositories. The classic approach is to use git send-email to the respective mailing list + maintainer.

#6 Updated by osmith 5 months ago

  • % Done changed from 50 to 90

I've sent out the patches to the maintainers directly (will use the respective mailing lists next time). Furthermore I've pushed a patch to fix "make distcheck" in libusrp and osmo-ci patches to enable libtelnet in gerrit-veritifcations and to use contrib/jenkins.sh for libosmo-dsp. When these last patches are merged, then the issue is done:

https://gerrit.osmocom.org/q/topic:make-maintainer-clean+status:open

#7 Updated by osmith 5 months ago

  • Status changed from In Progress to Resolved
  • % Done changed from 90 to 100

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)