Project

General

Profile

Actions

Bug #3232

closed

osmo-msc: configure.ac: pkgconfig for libsmpp34 called twice

Added by pespin almost 6 years ago. Updated almost 6 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Start date:
05/03/2018
Due date:
% Done:

0%

Resolution:
Spec Reference:

Description

First it's included unconditionally:

PKG_CHECK_MODULES(LIBSMPP34, libsmpp34 >= 1.13.0)

Then, conditionally:

# Enable/disable smpp support in the msc?
AC_ARG_ENABLE([smpp], [AS_HELP_STRING([--enable-smpp], [Build the SMPP interface])],
    [osmo_ac_build_smpp="$enableval"],[osmo_ac_build_smpp="no"])
if test "$osmo_ac_build_smpp" = "yes" ; then
    PKG_CHECK_MODULES(LIBSMPP34, libsmpp34 >= 1.13)
    AC_DEFINE(BUILD_SMPP, 1, [Define if we want to build SMPP])
fi
AM_CONDITIONAL(BUILD_SMPP, test "x$osmo_ac_build_smpp" = "xyes")
AC_SUBST(osmo_ac_build_smpp)

That's wrong. Find out if removing the unconditional one is enough.

Actions #1

Updated by laforge almost 6 years ago

  • Assignee changed from pespin to stsp
Actions #2

Updated by stsp almost 6 years ago

It looks like the unconditional check was added erroneously in osmo-msc commit a55dda703fc5e367bd58b5f9f6986d62ffbbdb6c
I suppose the author of that change overlooked the --enable-smpp configure option?

Coresponding gerrit change is: https://gerrit.osmocom.org/#/c/osmo-msc/+/5139/

I would say it is safe to remove the unconditional check.

Actions #3

Updated by stsp almost 6 years ago

  • Status changed from New to In Progress

Patch to remove the unconditional check: https://gerrit.osmocom.org/#/c/osmo-msc/+/9220

Actions #4

Updated by stsp almost 6 years ago

  • Status changed from In Progress to Resolved

Above change has been merged.

Actions

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)