OsmocomBB

The performance problem is actually caused by blocking calls of src/pq_alsa.c/pq_cb_alsa_input()/snd_pcm_readi().
Setting both buffer and period size values seems to solve the issue. A separate issue needs to be created...

fixeria wrote in #note-10:

After rebasing fixeria/audio on top of the recent master I got the audio working with Mot C1xx.
Still need to test with trxcon. Will update commit messages and submit patches to Gerrit soon.

Commit messages updated, all patches submitted for review:

https://gerrit.osmocom.org/c/osmocom-bb/+/30324 layer23: l1ctl_tx_traffic_req(): cosmetic: drop dead code [NEW]
https://gerrit.osmocom.org/c/osmocom-bb/+/30325 mobile: add MNCC socket path to settings [NEW]
https://gerrit.osmocom.org/c/osmocom-bb/+/30326 mobile: add MNCC handler selection to settings [NEW]
https://gerrit.osmocom.org/c/osmocom-bb/+/30327 mobile: allow enabling/disabling handling of voice in the L1PHY [NEW]
https://gerrit.osmocom.org/c/osmocom-bb/+/30328 mobile: gsm48_rr_set_mode(): print name of channel mode [NEW]
https://gerrit.osmocom.org/c/osmocom-bb/+/30329 mobile: gsm48_rr_set_mode(): check rc of rsl_dec_chan_nr() [NEW]
https://gerrit.osmocom.org/c/osmocom-bb/+/30330 mobile: gsm48_rr_set_mode(): print error if ch_type is not TCH [NEW]
https://gerrit.osmocom.org/c/osmocom-bb/+/30331 mobile: gsm48_rr_set_mode(): fix copy-paste in comment [NEW]
https://gerrit.osmocom.org/c/osmocom-bb/+/30332 mobile: properly handle RR CHANNEL MODE MODIFY message [NEW]
https://gerrit.osmocom.org/c/osmocom-bb/+/30333 mobile: gsm48_rr_tx_voice(): drop TCH/F channel limitation [NEW]
https://gerrit.osmocom.org/c/osmocom-bb/+/30334 mobile: voice.h: use '#pragma once' include guard [NEW]
https://gerrit.osmocom.org/c/osmocom-bb/+/30335 mobile: voice.h: add missing forward declarations [NEW]
https://gerrit.osmocom.org/c/osmocom-bb/+/30336 mobile: split gsm_send_voice() -> gsm_send_voice_{msg,frame}() [NEW]
https://gerrit.osmocom.org/c/osmocom-bb/+/30337 mobile: integrate GAPK based audio (voice) I/O support [NEW]

I also force-pushed to https://cgit.osmocom.org/osmocom-bb/log/?h=fixeria/audio.

All patches have been merged, so I removed https://cgit.osmocom.org/osmocom-bb/log/?h=fixeria/audio.

https://gerrit.osmocom.org/c/osmocom-bb/+/30454 mobile: clean up GAPK I/O state on channel release [NEW]
https://gerrit.osmocom.org/c/osmocom-bb/+/30455 mobile: support RTP and TI specific TCH frame I/O formats [NEW]

With a few additional patches applied:

https://gerrit.osmocom.org/c/osmocom-bb/+/30483 mobile: do not enforce RTP format for Uplink TCH frames [NEW]
https://gerrit.osmocom.org/c/osmocom-bb/+/30484 firmware: remove TCH/F specific bit re-ordering [NEW]
https://gerrit.osmocom.org/c/gapk/+/30482 libgsmhr/fetch_sources.py: convert to Python 3

I have successfully tested GAPK based audio I/O with both trxcon and a Mot C1xx phone. The non-adaptive codecs (HR, FR, EFR) are all confirmed to work. AMR implementation is currently incomplete in trxcon, and is completely missing in the layer1 firmware (needs DSP patches); adding a checklist item for this. I think at the current state it qualifies as a working voice call functionality, so I am stopping to work on this ticket and setting it to Stalled.

laforge wrote in #note-16:

IMHO it makes mor sence to resolve this ticket once all patches for non-AMR are merged. Add a new issue for
AMR support, with no assignee and low priority.

Ack, please see #5812.

See #5815.

Waiting for patches to be merged:

https://gerrit.osmocom.org/q/topic:mobile/audio+status:open

All patches have been merged. Voice quality is good, except when using libgsmhr (via libosmo-gapk.so). This can be investigated later.