Project

General

Profile

Actions

Bug #3496

closed

osmo-bsc: load of misaligned address in abis_nm_rx_ipacc

Added by pespin over 5 years ago. Updated over 5 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
A-bis OML
Target version:
-
Start date:
08/23/2018
Due date:
% Done:

0%

Spec Reference:

Description

Got this in osmo-gsm-tester while testing multiTRX nanoBTS, but I guess it appears too with only 1 TRX.

20180823165037231 DNM <0004> abis_nm.c:218 OC=BASEBAND-TRANSCEIVER(04) INST=(00,00,ff): STATE CHG: OP_STATE=Disabled AVAIL=Dependency(05) ADM=Unlocked
20180823165037235 DNM <0004> abis_nm.c:702 OC=BASEBAND-TRANSCEIVER(04) INST=(00,00,ff): bts=0 trx=0 Opstart ACK
20180823165037242 DNM <0004> abis_nm.c:2653 OC=BASEBAND-TRANSCEIVER(04) INST=(00,00,ff): IPACCESS(0xe1): RSL CONNECT ACK IP=10.42.42.7 abis_nm.c:2665:4: runtime error: load of misaligned address 0x61b00002d28d for type 'uint16_t', which requires 2 byte alignment
0x61b00002d28d: note: pointer points here
 2a 2a 07 81 0b bb 00  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  00
             ^
PORT=3003 STREAM=0x00
20180823165037265 DNM <0004> abis_nm.c:837 OC=RADIO-CARRIER(02) INST=(00,00,ff): Set Radio Carrier Attributes ACK

The issue is in osmo-bsc/src/osmo-bsc/abis_nm.c:2665, in function abis_nm_rx_ipacc:

    case NM_MT_IPACC_RSL_CONNECT_ACK:
        DEBUGPC(DNM, "RSL CONNECT ACK ");
        if (TLVP_PRESENT(&tp, NM_ATT_IPACC_DST_IP)) {
            memcpy(&addr,
                TLVP_VAL(&tp, NM_ATT_IPACC_DST_IP), sizeof(addr));

            DEBUGPC(DNM, "IP=%s ", inet_ntoa(addr));
        }
        if (TLVP_PRESENT(&tp, NM_ATT_IPACC_DST_IP_PORT))
            DEBUGPC(DNM, "PORT=%u ",                       2665: HERE!!!!!!!!!!!!!!!!!!!!!!!!
                ntohs(*((uint16_t *)
                    TLVP_VAL(&tp, NM_ATT_IPACC_DST_IP_PORT))));

Actions #2

Updated by stsp over 5 years ago

  • Status changed from New to In Progress
Actions #3

Updated by stsp over 5 years ago

Current status: Above patch is still waiting for review.

Actions #4

Updated by stsp over 5 years ago

  • Status changed from In Progress to Resolved

Above patch has been merged. Closing this issue.

Actions

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)