Project

General

Profile

Actions

Bug #3574

closed

osmo-bts: Drop -t parameter, allocate number of trx from cfg file

Added by pespin over 5 years ago. Updated over 5 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Start date:
09/19/2018
Due date:
% Done:

100%

Spec Reference:

Description

It's a common issue that people forgets to pass "-t 2" parameter when running a BTS with 2 TRX. That parameter is really not needed as we already have the TRX information in the bts-trx cfg files. We should change the logic in there to allocate the TRX structs from cfg VTY instead of relying on that parameter, then we can remove it.

Actions #1

Updated by pespin over 5 years ago

osmo-bsc already does that for each bts in config, see osmo-bsc.git/src/osmo-bsc/bsc_vty.c and grep for "cfg_trx_cmd".

Actions #2

Updated by pespin over 5 years ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 90
Actions #3

Updated by pespin over 5 years ago

  • Status changed from Feedback to Resolved
  • % Done changed from 90 to 100

Merged, closing.

Actions #4

Updated by pespin over 5 years ago

For reference, patch merged above has a bug, and this patch fixes it:
https://gerrit.osmocom.org/#/c/osmo-bts/+/11864 bts: Fix TRX0 param initialization

Actions

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)