Project

General

Profile

Actions

Bug #3673

closed

chopped LCO

Added by dexter over 5 years ago. Updated about 5 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
10/26/2018
Due date:
% Done:

100%

Spec Reference:

Description

(see trace) The codec name that that is transmitted in the LCO of the first CRCX is expected to re-appear in the SDP of the following 200 OK message. When inspecting the SDP of the following/second message, one can see that the last character of the codec name is missing. Since such a behavior can not observed when the codec was transmitted via SDP, the problem presumably is in the LCO parser.


Files

trace_chopped_lco.pcapng trace_chopped_lco.pcapng 4.21 KB dexter, 10/26/2018 12:20 PM
Actions #1

Updated by dexter over 5 years ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 90

I managed to pinpoint the problem. The LCO parser used a very tight buffer. 8 chars may seem to be enough for most codec names, GSM-HR-08 is 9 chars long. I think doubling the buffer will offer enough space for all codec names.

https://gerrit.osmocom.org/#/c/osmo-mgw/+/11466 mgcp_protocol: increase buffer space for codec name in LCO

Actions #2

Updated by dexter about 5 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 90 to 100

The related patch is merged, I think we can close this now.

Actions

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)