https://osmocom.org/https://osmocom.org/favicon.ico?16647414092020-06-21T13:54:07ZOpen Source Mobile CommunicationsOsmoBSC - Bug #3679: bsc_vty.c iterates trx to regen sysinfo manually, skips bcch_change_mark bumphttps://osmocom.org/issues/3679?journal_id=188322020-06-21T13:54:07Zlaforge
<ul><li><strong>Status</strong> changed from <i>Feedback</i> to <i>In Progress</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>70</i></li></ul><p>Patch in <a class="external" href="https://gerrit.osmocom.org/c/osmo-bsc/+/18938">https://gerrit.osmocom.org/c/osmo-bsc/+/18938</a></p> OsmoBSC - Bug #3679: bsc_vty.c iterates trx to regen sysinfo manually, skips bcch_change_mark bumphttps://osmocom.org/issues/3679?journal_id=189062020-06-23T22:02:02Zneelsnhofmeyr@sysmocom.de
<ul></ul><p>related, I'm not sure about this at all, but I now also notice a possible similar problem in bootstrap_rsl() in osmo_bsc_main.c:</p>
<pre>
static void bootstrap_rsl(struct gsm_bts_trx *trx)
{
[...]
gsm_bts_trx_set_system_infos(trx);
</pre>
<pre>
static int inp_sig_cb(unsigned int subsys, unsigned int signal,
void *handler_data, void *signal_data)
{
[...]
switch (signal) {
case S_L_INP_TEI_UP:
[...]
if (isd->link_type == E1INP_SIGN_RSL)
bootstrap_rsl(trx);
</pre>
<p>So whenever a BTS reconnects and brings a TRX up, there is no bcch_change_mark increment,<br />because this only calls gsm_bts_TRX_set_system_infos() and not gsm_BTS_set_system_infos().<br />Is that fine?</p> OsmoBSC - Bug #3679: bsc_vty.c iterates trx to regen sysinfo manually, skips bcch_change_mark bumphttps://osmocom.org/issues/3679?journal_id=189072020-06-24T05:26:16Zlaforge
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Resolved</i></li><li><strong>% Done</strong> changed from <i>70</i> to <i>100</i></li></ul><p>patch merged</p>