Project

General

Profile

Actions

Bug #3791

closed

OsmoBTS doesn't include the "IPA Destination IP Address" attribute in "IPA RSL Connect ACK"

Added by laforge almost 3 years ago. Updated 10 months ago.

Status:
Resolved
Priority:
Low
Assignee:
Category:
Abis
Target version:
-
Start date:
02/07/2019
Due date:
% Done:

100%

Spec Reference:

Description

Unlike a nanoBTS, OsmoBTS doesn't return the "IPA Destination IP Address" attribute in "IPA RSL Connect ACK" in response to a "IPA RSL Connect"


Related issues

Related to OsmoBTS - Feature #2469: Proper OML MO (managed object) using osmo_fsmResolvedpespin08/29/2017

Actions
Actions #1

Updated by laforge almost 3 years ago

  • Related to Feature #2469: Proper OML MO (managed object) using osmo_fsm added
Actions #2

Updated by laforge 10 months ago

  • Assignee changed from laforge to fixeria
Actions #3

Updated by fixeria 10 months ago

As far as I can see, osmo-bts does reuse the received message buffer by changing the message type and sending it back. Thus if the IPA RSL Connect does not connect the Destination IP Address, then the ACK would not contain it too. So do we want to have this attribute in the ACK regardless of its presence in the request?

Actions #4

Updated by fixeria 10 months ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 80

remote: https://gerrit.osmocom.org/c/osmo-bts/+/22760 oml: cosmetic code style changes in rx_oml_ipa_rsl_connect() [NEW]
remote: https://gerrit.osmocom.org/c/osmo-bts/+/22761 oml: avoid redundant ntohl() / htonl() conversion [NEW]
remote: https://gerrit.osmocom.org/c/osmo-bts/+/22762 oml: make 'struct tlv_parsed' pointer const where possible [NEW]
remote: https://gerrit.osmocom.org/c/osmo-bts/+/22763 oml: reuse the given msgb in oml_fom_ack_nack() [NEW]
remote: https://gerrit.osmocom.org/c/osmo-bts/+/22764 oml: use regular TLVP_PRES() in rx_oml_ipa_rsl_connect() [NEW]
remote: https://gerrit.osmocom.org/c/osmo-bts/+/22765 oml: ensure that IPA RSL Connect ACK/NACK contains all IEs [NEW]

Actions #5

Updated by laforge 10 months ago

On Sat, Feb 06, 2021 at 01:35:18PM +0000, fixeria [REDMINE] wrote:

As far as I can see, osmo-bts does reuse the received message buffer by changing the message type and sending it back. Thus if the IPA RSL Connect does not connect the Destination IP Address, then the ACK would not contain it too. So do we want to have this attribute in the ACK regardless of its presence in the request?

yes, it should basically confirm the actual address RSL has connected to.

Actions #6

Updated by laforge 10 months ago

  • Status changed from Feedback to Resolved
  • % Done changed from 80 to 100

patch merged

Actions

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)