Project

General

Profile

Actions

Bug #4149

open

osmo_fsm allows event names to have spaces in them

Added by laforge almost 3 years ago. Updated 4 months ago.

Status:
New
Priority:
Normal
Assignee:
Category:
libosmocore
Target version:
-
Start date:
08/13/2019
Due date:
% Done:

0%

Spec Reference:

Description

See https://gerrit.osmocom.org/#/c/libosmocore/+/15154/

event names, like state names, should be one word only.

Actions #1

Updated by laforge almost 3 years ago

we call osmo_identifier_valid() for the FSM name and FSM instance, but we don't appear to use it for state or event names :(

Actions #2

Updated by Anonymous over 2 years ago

Actions #3

Updated by laforge over 2 years ago

Actions #4

Updated by laforge about 1 year ago

  • Category set to libosmocore
Actions #5

Updated by dexter 4 months ago

the initial patch breaks, as expected, a lot of existing FSMs, we need to resolve this first. Unfortunately there is also a problem with the debug log. Some FSMs are registered before the log is initialized. The logging framework will then exit with an assertion when the debug messages from the FSM registrations are printed. This needs to be resolved first to debug the problematic. See also: https://gerrit.osmocom.org/c/libosmocore/+/26950

Actions

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)