Project

General

Profile

Bug #4149

osmo_fsm allows event names to have spaces in them

Added by laforge over 1 year ago. Updated 23 days ago.

Status:
New
Priority:
Normal
Assignee:
Category:
libosmocore
Target version:
-
Start date:
08/13/2019
Due date:
% Done:

0%

Spec Reference:

Description

See https://gerrit.osmocom.org/#/c/libosmocore/+/15154/

event names, like state names, should be one word only.

Associated revisions

Revision ed2e1f18 (diff)
Added by laforge 2 months ago

osmo_fsm: Ensure all state and event names are valid identifiers

we call osmo_identifier_valid() for the FSM name and FSM instance, but we
forgot to do so for all the state and event names. This meant that they
could contain spaces and the like, which in turn might create problems
when exposing FSM state over CTRL.

This patch shouldn't be merged as-is right now. We first have to
use it to determine which of our existing programs have related issues.

Change-Id: If98587eff3c48a66ed2e5cc1f01a12accab5a3e7
Closes: OS#4149

History

#1 Updated by laforge over 1 year ago

we call osmo_identifier_valid() for the FSM name and FSM instance, but we don't appear to use it for state or event names :(

#2 Updated by Anonymous over 1 year ago

#3 Updated by laforge over 1 year ago

#4 Updated by laforge 23 days ago

  • Category set to libosmocore

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)