Project

General

Profile

Bug #4284

Dynamic ASPs get saved in the config

Added by roch over 1 year ago. Updated over 1 year ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
-
Start date:
11/28/2019
Due date:
% Done:

100%

Spec Reference:

Description

Hi,

I see that dynamic ASPs get saved in the configuration file when doing a wr mem but
make osmo-stp fail to start because they aren't defined anywhere.

Here's the startup log:
root@rbx-dev-telnahub-1:~# osmo-stp -c /etc/osmocom/osmo-stp.cfg
Copyright (C) 2015-2017 by Harald Welte <>
Contributions by Holger Freyther, Neels Hofmeyr
License GPLv2+: GNU GPL Version 2 or later <http://gnu.org/licenses/gpl-2.0.html>
This is free software: you are free ot change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Free Software lives by contribution. If you use this, please contribute!

DLSS7 <000c> osmo_ss7.c:368 0: Creating SS7 Instance
DLSS7 <000c> osmo_ss7.c:668 0: Creating Route Table system
DLSS7 <000c> osmo_ss7.c:1324 0: asp-stp2: Restarting ASP stp2, r=199.255.7.133:2919<->l=(10.26.30.247|10.26.31.247):2919
DLSS7 <000c> fsm.c:461 XUA_ASP(stp2){ASP_DOWN}: Allocated
DLSS7 <000c> fsm.c:461 XUA_AS(STP2){AS_DOWN}: Allocated
DLSS7 <000c> osmo_ss7.c:970 0: as-STP2: Created AS
DLSS7 <000c> osmo_ss7.c:990 0: as-STP2: Adding ASP stp2 to AS
DLSS7 <000c> fsm.c:461 XUA_AS(telnahub){AS_DOWN}: Allocated
DLSS7 <000c> osmo_ss7.c:970 0: as-telnahub: Created AS
Error occurred during reading the below line:
asp asp-dyn-0

cannot find ASP 'asp-dyn-0'
Failed to parse the config file '/etc/osmocom/osmo-stp.cfg'

Associated revisions

Revision 362141cc (diff)
Added by laforge over 1 year ago

Skip dynamic ASPs when writing the list of ASPs in an AS

we handle this correctly in not writing the actual "asp" configuration,
but we have a bug when writing the list of asps within one "as". Let's
make sure to skip the dynamically-created ASPs there, too.

Change-Id: I1a184f3ddec2e91ced8c95ada224da8b490407a8
Closes: OS#4284

History

#1 Updated by laforge over 1 year ago

  • Assignee set to laforge

#2 Updated by laforge over 1 year ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 80

Thanks. We handle this correctly in not writing the actual "asp" configuration, but we have a bug when writing the list of asps within one "as".

should be fixed in https://gerrit.osmocom.org/c/libosmo-sccp/+/16305 - feel free to test and provide feedback.

#3 Updated by laforge over 1 year ago

  • Status changed from In Progress to Resolved
  • % Done changed from 80 to 100

patch merged

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)