Feature #4369
closedtry to get changes from https://github.com/herlesupreeth/pysim merged
100%
Description
Supreeth Herle has been doing quite a few improvements to pySim, let's try to get those merged.
I've reached out to him and asked if he would submit his changes to our gerrit for review.
Updated by laforge over 4 years ago
- % Done changed from 0 to 10
herlesupreeth has indicated he would be looking into submitting his changes. Thanks!
Updated by fixeria about 4 years ago
- % Done changed from 10 to 90
Most of the changes submitted by herlesupreeth have been merged. One of them got stuck:
https://gerrit.osmocom.org/c/pysim/+/16991
plus there is a couple more changes in https://github.com/herlesupreeth/pysim:
https://github.com/herlesupreeth/pysim/commit/b274b0ea1c633524aef126db8d945654f464bd3b
https://github.com/herlesupreeth/pysim/commit/95bac734974980278a892df1f9ea7e4b82885144
Updated by laforge about 4 years ago
- Status changed from New to In Progress
- Assignee changed from laforge to herlesupreeth
Updated by laforge over 3 years ago
what's the geenral status here? Do you still have lots of out-of-tree changes, herlesupreeth?
Updated by herlesupreeth over 3 years ago
Not much, i have three more commits but are very less important. I will try to get it merged as soon as possible
Updated by laforge almost 2 years ago
- Status changed from In Progress to Feedback
As this has been "in progress" for a year by now: Do you still have any patches that should be merged to pysim, supreeth? Otherwise we should probably close this task.
Updated by herlesupreeth almost 2 years ago
I don't think there are any more commits to be merged to pysim. py-shell covers all the cases. This can be closed.
Updated by laforge almost 2 years ago
- Status changed from Feedback to Resolved
- % Done changed from 90 to 100