Bug #4399: remsim-client not informed if slotmap is deleted - osmo-remsim - Open Source Mobile Communications

Actions

Copy link

Bug #4399

closed

remsim-client not informed if slotmap is deleted

Added by laforge about 4 years ago. Updated about 4 years ago.

Status:

Resolved

Priority:

Normal

Assignee:

laforge

Category:

Target version:

Start date:

02/15/2020

Due date:

% Done:

100%

Spec Reference:

Description

In the following sequence of events:

bankd + client connected to server
slotmap is established via RSRES
slotmap is communicated to client + bankd
communication happens ...
slotmap is removed via RSRES
slotmap is removed from bankd

There appears to be no communication to the client about the slotmap being removed.

Files

OS4339-2.pcap

14.3 KB

laforge, 02/15/2020 07:38 PM

Actions

Copy link

Updated by laforge about 4 years ago

File OS4339-2.pcap OS4339-2.pcap added

As we can see in the attached OS4339-2.pcap, there is a ConfigClientBankReq sent to the client when the mapping is created, but there is none when the mapping is removed. On removal time, only a removeMappingReq to the bankd can be seen.

Actions

Copy link

Updated by laforge about 4 years ago

Status changed from New to In Progress
% Done changed from 0 to 10

Indeed, rspro_server.c contains a related FIXME:

static void clnt_st_connected_bankd(struct osmo_fsm_inst *fi, uint32_t event, void *data)
{
...
        switch (event) {
...
        case CLNTC_E_REMOVE_MAP_RES: /* Bankd acknowledges mapping was removed */
...
                /* slotmap_del() will remove it from both global and bank list */
                slotmap_del(map->maps, map);
                /* FIXME: update client! */

Actions

Copy link