Actions
Bug #4447
openDSCP value should be a 6 bit field
Start date:
03/09/2020
Due date:
% Done:
0%
Spec Reference:
Description
TOS was 8bits, but only the upper 6 bits became DSCP. The VTY command for DSCP in OsmoMGW accepts an 8 bit value. We are setting the setsockopt for TOS with that value without bit-shifting.
This came up while writing a similar patch for setting DSCP for OsmoBTS.
Should we
a) shift it two bits up and adjust the command syntax (and config template) to restrict to 0..63 (backwards incompatible)
or
b) change the description of the VTY command, so it is obvious that we are actually setting the TOS? (probably confusing)
CC: laforge
Related issues
Actions