Project

General

Profile

Bug #4679

osmo-trx: Add rate-ctr for clipping

Added by pespin about 1 year ago. Updated about 1 year ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Start date:
07/24/2020
Due date:
% Done:

100%

Spec Reference:

Description

As seen on my limenet-mico3 while running some stability test, lot's of these messages may swamp the stderr log at some point. Let's try to avoid printing each time or completely dropping the log line, and use a rate_ctr instead.

Jul 24 17:42:31 limenet-micro3 osmo-trx-lms[815]: Fri Jul 24 17:42:31 2020 DTRXDUL <0004> Transceiver.cpp:717 [tid=1910488272][chan=0] Clipping detected on received RACH or Normal Burst
Jul 24 17:42:31 limenet-micro3 osmo-trx-lms[815]: Fri Jul 24 17:42:31 2020 DTRXDUL <0004> Transceiver.cpp:717 [tid=1910488272][chan=0] Clipping detected on received RACH or Normal Burst
Jul 24 17:42:31 limenet-micro3 osmo-trx-lms[815]: Fri Jul 24 17:42:31 2020 DTRXDUL <0004> Transceiver.cpp:717 [tid=1910488272][chan=0] Clipping detected on received RACH or Normal Burst
Jul 24 17:42:31 limenet-micro3 osmo-trx-lms[815]: Fri Jul 24 17:42:31 2020 DTRXDUL <0004> Transceiver.cpp:717 [tid=1910488272][chan=0] Clipping detected on received RACH or Normal Burst
Jul 24 17:42:31 limenet-micro3 osmo-trx-lms[815]: Fri Jul 24 17:42:31 2020 DTRXDUL <0004> Transceiver.cpp:717 [tid=1910488272][chan=0] Clipping detected on received RACH or Normal Burst
Jul 24 17:42:31 limenet-micro3 osmo-trx-lms[815]: Fri Jul 24 17:42:31 2020 DTRXDUL <0004> Transceiver.cpp:717 [tid=1910488272][chan=0] Clipping detected on received RACH or Normal Burst
Jul 24 17:42:31 limenet-micro3 osmo-trx-lms[815]: Fri Jul 24 17:42:31 2020 DTRXDUL <0004> Transceiver.cpp:717 [tid=1910488272][chan=0] Clipping detected on received RACH or Normal Burst
Jul 24 17:42:31 limenet-micro3 osmo-trx-lms[815]: Fri Jul 24 17:42:31 2020 DTRXDUL <0004> Transceiver.cpp:717 [tid=1910488272][chan=0] Clipping detected on received RACH or Normal Burst
Jul 24 17:42:31 limenet-micro3 osmo-trx-lms[815]: Fri Jul 24 17:42:31 2020 DTRXDUL <0004> Transceiver.cpp:717 [tid=1910488272][chan=0] Clipping detected on received RACH or Normal Burst
Jul 24 17:42:31 limenet-micro3 osmo-trx-lms[815]: Fri Jul 24 17:42:31 2020 DTRXDUL <0004> Transceiver.cpp:717 [tid=1910488272][chan=0] Clipping detected on received RACH or Normal Burst
Jul 24 17:42:31 limenet-micro3 osmo-trx-lms[815]: Fri Jul 24 17:42:31 2020 DTRXDUL <0004> Transceiver.cpp:717 [tid=1910488272][chan=0] Clipping detected on received RACH or Normal Burst
Jul 24 17:42:31 limenet-micro3 osmo-trx-lms[815]: Fri Jul 24 17:42:31 2020 DTRXDUL <0004> Transceiver.cpp:717 [tid=1910488272][chan=0] Clipping detected on received RACH or Normal Burst
Jul 24 17:42:31 limenet-micro3 osmo-trx-lms[815]: Fri Jul 24 17:42:31 2020 DTRXDUL <0004> Transceiver.cpp:717 [tid=1910488272][chan=0] Clipping detected on received RACH or Normal Burst
Jul 24 17:42:31 limenet-micro3 osmo-trx-lms[815]: Fri Jul 24 17:42:31 2020 DTRXDUL <0004> Transceiver.cpp:717 [tid=1910488272][chan=0] Clipping detected on received RACH or Normal Burst
Jul 24 17:42:31 limenet-micro3 osmo-trx-lms[815]: Fri Jul 24 17:42:31 2020 DTRXDUL <0004> Transceiver.cpp:717 [tid=1910488272][chan=0] Clipping detected on received RACH or Normal Burst
Jul 24 17:42:31 limenet-micro3 osmo-trx-lms[815]: Fri Jul 24 17:42:31 2020 DTRXDUL <0004> Transceiver.cpp:717 [tid=1910488272][chan=0] Clipping detected on received RACH or Normal Burst
Jul 24 17:42:31 limenet-micro3 osmo-trx-lms[815]: Fri Jul 24 17:42:31 2020 DTRXDUL <0004> Transceiver.cpp:717 [tid=1910488272][chan=0] Clipping detected on received RACH or Normal Burst
Jul 24 17:42:31 limenet-micro3 osmo-trx-lms[815]: Fri Jul 24 17:42:31 2020 DTRXDUL <0004> Transceiver.cpp:717 [tid=1910488272][chan=0] Clipping detected on received RACH or Normal Burst

Associated revisions

Revision 1d165a04 (diff)
Added by pespin about 1 year ago

Transceiver: Add several rate_ctr for rx error conditions

Since there's now a rate counter, we can drop log level for those events
which can be bursty and hence print lots of output in short periods of
time, which may affect performance. This way setting them to INFO it's
enough to avoid getting them in stderr unless explicitly configured by
the user (for instance to debug stuff), while still allowing a good
enough level to be enabled for other targets such as gsmtap.

Related: OS#4679
Change-Id: I000f7112e35ac68d3d922444f78468b1ea74cbba

History

#1 Updated by ipse about 1 year ago

Good idea about adding stats for this.

But please do not remove this log output - it's useful when debugging. Just move it to DEBUG level.

#2 Updated by laforge about 1 year ago

I think it's not just clipping. There are many situations (also seen in SYS#5014) which
are potentially happening at every burst:
  • empty burst (no energy in the channel)
  • clipping detected
  • no RACH or NB detected

We should have counter for (at least) all of these.

Given that we may have different radio carrier (ARFCN) and TS, the counters should
exist at least on a per-carrier basis, if not even on a per-TS basis.

#3 Updated by pespin about 1 year ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 90

Available here: https://gerrit.osmocom.org/c/osmo-trx/+/19403 Transceiver: Add several rate_ctr for rx error conditions

Once merged the ticket can be closed.

#4 Updated by pespin about 1 year ago

  • Status changed from Feedback to Resolved
  • % Done changed from 90 to 100

Merged, closing.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)