Project

General

Profile

Bug #4710

osmo_sockaddr gtphub jenkins fallout

Added by laforge 9 months ago. Updated 9 months ago.

Status:
Closed
Priority:
Urgent
Assignee:
Category:
-
Target version:
-
Start date:
08/13/2020
Due date:
% Done:

100%

Spec Reference:

Description

The jenkins job that tests the build of old applications against current libraries in 'master' is failing:
https://jenkins.osmocom.org/jenkins/job/Osmocom-build-tags-against-master/536/console

This is not unexpected. However, the job needs to be modified to pass again, ideally by
  • just disabling the gtphub (applying some patch before build), or
  • by tagging patch releases for all the tested application versions that cherry-pick the struct rename patch (1.5.0, 1.6.0, 1.6.1)

Simply not testing builds of osmo-sgsn against current master libraries is not an option.

Associated revisions

Revision dd930a25 (diff)
Added by lynxis 10 months ago

gtphub: rename sgsn's oww osmo_sockaddr into sgsn_sockaddr

The osmo_ prefix should be only used for official struct/apis of libosmocore.
This commit was done via `sed -i 's/osmo_sockaddr/sgsn_sockaddr/g'`.

In prepartion of introducing a different api of osmo_sockaddr to
libosmocore.

Change-Id: Ibb1ddce9ff1ffe7494de5cdb8ea1843c45fe4566

History

#1 Updated by laforge 9 months ago

For 1.6.1 I am tagging a 1.6.2: https://gerrit.osmocom.org/c/osmo-sgsn/+/19614

#3 Updated by laforge 9 months ago

1.6.2 worked, the 1.5.1 fails to build. I'm not going to investigate this further; lynxis, please take care of this.

#4 Updated by lynxis 9 months ago

  • Status changed from New to In Progress

#5 Updated by lynxis 9 months ago

  • % Done changed from 0 to 50

The build 1.5.1 fails because of the python2 and python3 migration. The build check on the jenkins fails, because the missing python package osmopy.obscvty.
It's only installed for python3 but not python3.

I'm installing the (old) package as python2.

#6 Updated by lynxis 9 months ago

waiting for review of https://gerrit.osmocom.org/c/osmo-ci/+/19661 to fix the jenkins build failures.

#7 Updated by lynxis 9 months ago

  • Status changed from In Progress to Feedback
  • % Done changed from 50 to 70

#8 Updated by lynxis 9 months ago

  • Status changed from Feedback to In Progress

#9 Updated by lynxis 9 months ago

  • Status changed from In Progress to Feedback

The gerrit patches aren't checked by the node itself, it's checked inside docker. even the jenkins nodes had the osmocom-python-tests installed under /usr/local.

Waiting for review another patch:
https://gerrit.osmocom.org/c/docker-playground/+/19663

#10 Updated by lynxis 9 months ago

  • Status changed from Feedback to Closed
  • % Done changed from 70 to 100

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)