Project

General

Profile

Actions

Bug #4736

closed

handover related rate counter increments are missing

Added by neels over 1 year ago. Updated over 1 year ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Start date:
08/29/2020
Due date:
% Done:

100%

Spec Reference:

Description

it seems that only {BSC,BTS}_CTR_HANDOVER_ATTEMPTED rate counters are ever incremented in the osmo-bsc.git source tree.
Add missing counter increments for handover, and add rate counter validation to the ttcn3-bsc-tests handover testing.

Actions #1

Updated by neels over 1 year ago

grepping for counter names doesn't cover it, because during handover, the counter names to increment are heavily composed by preproc macros:

result_counter_##obj##_##name() functions are called by result_counter_bsc() and result_counter_bts().
Then in handover_end() we have these to call the rate_ctr_inc() with the resulting counter number:

ho_count_bsc(result_counter_bsc(ho->scope, result));
ho_count_bts(bts, result_counter_bts(ho->scope, result));

So there appear to actually not be any missing counter increments.
Nevertheless take the opportunity to add counter validation to the ttcn3-bsc-tests, and make sure that these macros aren't buggy.

Actions #2

Updated by neels over 1 year ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 90
Actions #3

Updated by neels over 1 year ago

  • Status changed from In Progress to Resolved
  • % Done changed from 90 to 100

patches merged

Actions

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)