BTS features parsed too late
The BSC requests the BTS features after it has used to decide if the BTS can be used for IPv6.
Introduce NM GPRS NSE FSM
Introduce NM GPRS CELL FSM
Introduce NM GPRS NSVC FSM
abis_nm: Simplify param passing to abis_nm_rx_get_attr_resp()
There's no real need to retrieve the trx before passing it to the
function, we can do that in the function itself and hence also simplify
the function itself.
Handle BTS/BBTRANSC Get Attributes (Ack) in NM FSMs
Before this patch, Get Attributes was sent quicklyafter the OML link
became up, even if the BTS/BB_TRANSC objects were still powered off,
which is wrong since attributes should only be available after the
objects transition out of the Power off state.
Furthermore, information about get attr response already received will
be required in future patches to delay NSVC setting.
oml: Delay configuring NSVC until BTS features are negotiated
This is needed in order to to proper feature support verification for
IPv6 when configuring the NSVC.
Before this patch, there could be a race condition where NSVC FSM
checked for BTS feature BTS_FEAT_IPV6_NSVC before it was negotiated
through BTS Get Attributes (Ack).
- File oml_too_late.pcapng oml_too_late.pcapng added
- Subject changed from BTS features requested too late to BTS features parsed too late
- Assignee changed from lynxis to pespin
The BSC parse the BTS features which are requested via "Get Attribute" too late to allow the NSVC MO to check for the IPv6 feature.
The BSC already generated the NSVC MO Set Attribute packet when it receives the "State Event Report" for the NSVC MO which is before the feature response is parsed.
So in general I would expect to parse the feature message before triggering any MO object response.
The problem is most probably that I didn't work on the FSMs for the gprs-related MO, such as NSVC, so those are still handled the old way by pushing everything quite quickly.So in order to solve this iiuc we need to:
- Implement FSM for misisng gprs-related MOs,
- In the BSC, Delay set up of NSVC MO until we received BTS Get Attributes Response.
- Status changed from New to Feedback
- % Done changed from 0 to 70
- % Done changed from 70 to 90
I reworked lynxis patches on top of mine adding FSMs for all GPRS-related MOs.
Issue should be fixed by these:
remote: https://gerrit.osmocom.org/c/osmo-bsc/+/21452 Introduce NM GPRS NSVC FSM
remote: https://gerrit.osmocom.org/c/osmo-bsc/+/21501 abis_nm: Simplify param passing to abis_nm_rx_get_attr_resp()
remote: https://gerrit.osmocom.org/c/osmo-bsc/+/21502 Handle BTS/BBTRANSC Get Attributes (Ack) in NM FSMs
remote: https://gerrit.osmocom.org/c/osmo-bsc/+/21538 Fix typo in function nanobts_attr_nsvc_get [NEW]
remote: https://gerrit.osmocom.org/c/osmo-bsc/+/21451 oml: Delay configuring NSVC until BTS features are negotiated