Bug #4887
ns2: Missing unittests
100%
Description
We are missing tests for ns2 under tests/
We should also test the VTY for ns2 to catch issues such as https://gerrit.osmocom.org/c/libosmocore/+/21459 before they get merged.
Related issues
Associated revisions
tests/gb: Add more complex osmo-ns-dummy.cfg
write config will not print out any configuration for bind/nse unless we
configure some. This way we can catch more issues with incompatible
configs such as https://gerrit.osmocom.org/c/libosmocore/+/22878
Change-Id: Iad422ee013c82a6cb96af8ce4eb3af8b0936a4c9
Related: OS#4887
History
#2 Updated by laforge 5 months ago
- Priority changed from Normal to High
We've now seen this again in https://gerrit.osmocom.org/c/libosmocore/+/21741 and https://gerrit.osmocom.org/c/libosmocore/+/21742/1 whic both caused failures only in the osmo-pcu tests, but not in libosmocore itself.
#6 Updated by daniel 3 months ago
See https://gerrit.osmocom.org/c/libosmocore/+/22878
The issue was that we aren't actually testing ns2 config if there are no binds/nse configured.
https://gerrit.osmocom.org/c/libosmocore/+/22879 tries to fix that
ns2: Fix incompatible VTY configs when writing config
It seems like we still don't have NS2 VTY tests running in libosmocore
so this only got caught once osmo-sgsn/osmo-gbproxy builds failed.
Change-Id: Id3cd407b05457a4703ee38c4b1b1b65800bbd30e
Related: OS#4887