Project

General

Profile

Bug #4887

ns2: Missing unittests

Added by daniel 6 months ago. Updated 3 months ago.

Status:
Resolved
Priority:
High
Assignee:
Category:
libosmogb
Target version:
-
Start date:
12/02/2020
Due date:
% Done:

100%

Spec Reference:

Description

We are missing tests for ns2 under tests/

We should also test the VTY for ns2 to catch issues such as https://gerrit.osmocom.org/c/libosmocore/+/21459 before they get merged.


Related issues

Related to libosmocore - Bug #5006: NS2: Wrong state for NSVC that never comes upNew02/03/2021

Associated revisions

Revision 64db6366 (diff)
Added by daniel 3 months ago

ns2: Fix incompatible VTY configs when writing config

It seems like we still don't have NS2 VTY tests running in libosmocore
so this only got caught once osmo-sgsn/osmo-gbproxy builds failed.

Change-Id: Id3cd407b05457a4703ee38c4b1b1b65800bbd30e
Related: OS#4887

Revision ae989956 (diff)
Added by daniel 3 months ago

tests/gb: Add more complex osmo-ns-dummy.cfg

write config will not print out any configuration for bind/nse unless we
configure some. This way we can catch more issues with incompatible
configs such as https://gerrit.osmocom.org/c/libosmocore/+/22878

Change-Id: Iad422ee013c82a6cb96af8ce4eb3af8b0936a4c9
Related: OS#4887

History

#1 Updated by laforge 6 months ago

  • Assignee set to lynxis

#2 Updated by laforge 5 months ago

  • Priority changed from Normal to High

We've now seen this again in https://gerrit.osmocom.org/c/libosmocore/+/21741 and https://gerrit.osmocom.org/c/libosmocore/+/21742/1 whic both caused failures only in the osmo-pcu tests, but not in libosmocore itself.

#3 Updated by lynxis 4 months ago

  • Status changed from New to In Progress

#4 Updated by lynxis 4 months ago

  • Status changed from In Progress to Stalled
  • % Done changed from 0 to 30

The vty tests has been implmented.

#5 Updated by daniel 3 months ago

  • Related to Bug #5006: NS2: Wrong state for NSVC that never comes up added

#6 Updated by daniel 3 months ago

See https://gerrit.osmocom.org/c/libosmocore/+/22878

The issue was that we aren't actually testing ns2 config if there are no binds/nse configured.

https://gerrit.osmocom.org/c/libosmocore/+/22879 tries to fix that

#7 Updated by lynxis 3 months ago

  • Status changed from Stalled to Resolved
  • % Done changed from 30 to 100

There are now vty tests and also a couple unit tests.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)