Project

General

Profile

Bug #4907

osmo-pcu: Convert gprs_ms::m_dl_ctrl_msg to rate_ctr

Added by pespin 5 months ago. Updated 4 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
-
Start date:
12/15/2020
Due date:
% Done:

100%

Spec Reference:

Description

$ ag dl_ctrl_msg
src/pcu_vty_functions.cpp
178:    vty_out(vty, "  RLC/MAC DL Control Msg: %d%s", ms->dl_ctrl_msg(),

src/gprs_rlcmac_sched.cpp
234:            tbf->ms()->update_dl_ctrl_msg();

src/gprs_ms.cpp
119:    m_dl_ctrl_msg(0)

src/gprs_ms.h
141:    unsigned dl_ctrl_msg() const;
142:    void update_dl_ctrl_msg();
199:    unsigned m_dl_ctrl_msg;
288:inline unsigned GprsMs::dl_ctrl_msg() const
290:    return m_dl_ctrl_msg;
293:inline void GprsMs::update_dl_ctrl_msg()
295:    m_dl_ctrl_msg++;

This is basically a rate counter. Let's get rid of getters, setters, specific variables, etc. and use rate counter APIs instead.

History

#1 Updated by pespin 4 months ago

  • Status changed from New to Feedback
  • Assignee set to pespin
  • % Done changed from 0 to 90

Done here:
https://gerrit.osmocom.org/c/osmo-pcu/+/22102 ms: Replace struct var with rate_ct

Ticket can be closed once patch is merged.

#2 Updated by pespin 4 months ago

  • Status changed from Feedback to Resolved
  • % Done changed from 90 to 100

Merged, closing.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)