Project

General

Profile

Feature #4912

make osmo-gsm-manuals part of the docker images

Added by laforge 2 months ago. Updated about 1 month ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
-
Start date:
12/17/2020
Due date:
% Done:

100%

Spec Reference:

Description

I don't think there is a lot be gained by re-building osmo-gsm-manuals all the time (via osmo-build-dep.sh osmo-gsm-manuals) from virtually every one of our build jobs. - particularly as that will do a 'make check" and hence build test user manuals every time.

I would guess it made more sense to simply include osmo-gsm-manuals.git into the build container. This way it is always pre-installed without having to explicitly install it.


Checklist

  • interim measure: workaround for 'osmo-build-dep.sh osmo-gsm-manuals' to only clone, not build
  • clone osmo-gsm-manuals in the docker image and on build slaves (for osmo-trx,bts which can't build in docker)
  • add job to trigger update-osmo-ci-on-slaves when pushing to osmo-gsm-manuals.git, so the build slaves and docker images always have the latest version of osmo-gsm-manuals
  • update OSMO_GSM_MANUALS_DIR
  • remove 'osmo-build-dep.sh osmo-gsm-manuals' from contrib/jenkins.sh of all projects
  • remove workaround for 'osmo-build-dep.sh osmo-gsm-manuals' again

Associated revisions

Revision 63519744 (diff)
Added by osmith about 1 month ago

contrib/jenkins: don't build osmo-gsm-manuals

Related: OS#4912
Change-Id: I8ab46680f9b753408e7ac6ef1635f997747325e5

Revision 1e2ff4a8 (diff)
Added by osmith about 1 month ago

contrib/jenkins: don't build osmo-gsm-manuals

Related: OS#4912
Change-Id: I511b2e1f4c3a9e0897cff4241ab5df12327de10d

Revision 220f0e2d (diff)
Added by osmith about 1 month ago

contrib/jenkins: don't build osmo-gsm-manuals

Related: OS#4912
Change-Id: I339cc37a259e30b131fadbdaebd413c54b04f0a0

Revision e8edd1fc (diff)
Added by osmith about 1 month ago

contrib/jenkins: don't build osmo-gsm-manuals

Related: OS#4912
Change-Id: Ibacb11da37acfd324cee37068099627136717781

Revision 3f64c7f7 (diff)
Added by osmith about 1 month ago

contrib/jenkins: don't build osmo-gsm-manuals

Related: OS#4912
Change-Id: I3fc43b1afb7cdfd2b78c062e36ccf2491700f988

Revision 120910c8 (diff)
Added by osmith about 1 month ago

contrib/jenkins: don't build osmo-gsm-manuals

Related: OS#4912
Change-Id: If655798bb47c332f7decb74ed19524b3014f69b4

History

#1 Updated by osmith about 2 months ago

  • Status changed from New to In Progress

#2 Updated by osmith about 2 months ago

  • % Done changed from 0 to 90

#3 Updated by osmith about 2 months ago

  • Checklist item interim measure: workaround for 'osmo-build-dep.sh osmo-gsm-manuals' to only clone, not build added
  • Checklist item clone osmo-gsm-manuals in the docker image and on build slaves (for osmo-trx,bts which can't build in docker) added
  • Checklist item add job to trigger update-osmo-ci-on-slaves when pushing to osmo-gsm-manuals.git, so the build slaves and docker images always have the latest version of osmo-gsm-manuals added
  • Checklist item update OSMO_GSM_MANUALS_DIR added
  • Checklist item remove 'osmo-build-dep.sh osmo-gsm-manuals' from contrib/jenkins.sh of all projects added
  • Checklist item remove workaround for 'osmo-build-dep.sh osmo-gsm-manuals' again added
  • % Done changed from 90 to 70

Setting the status back to 70%, as the initial patch is just a temporary solution (see review). I've updated the checklist, and I'm pretty far with unchecked tasks already, but I'm testing the changes some more before pushing the patches to gerrit.

#4 Updated by osmith about 1 month ago

master-osmo-e1-hardware failed in jenkins after merging 'osmo-build-dep.sh: don't build osmo-gsm-manuals' patch. Fix and two related patches:

EDIT: see #4943

#5 Updated by osmith about 1 month ago

  • Checklist item clone osmo-gsm-manuals in the docker image and on build slaves (for osmo-trx,bts which can't build in docker) set to Done
  • Checklist item add job to trigger update-osmo-ci-on-slaves when pushing to osmo-gsm-manuals.git, so the build slaves and docker images always have the latest version of osmo-gsm-manuals set to Done
  • Checklist item update OSMO_GSM_MANUALS_DIR set to Done

#6 Updated by osmith about 1 month ago

More patches submitted, topic for both this issue and #4911:
https://gerrit.osmocom.org/q/topic:no-path-no-manuals-build

#7 Updated by osmith about 1 month ago

  • Checklist item remove 'osmo-build-dep.sh osmo-gsm-manuals' from contrib/jenkins.sh of all projects set to Done

remove 'osmo-build-dep.sh osmo-gsm-manuals' from contrib/jenkins.sh of all projects

Done for all the projects I had checked out (if I missed one, I'll add it as soon as it fails on jenkins):
https://gerrit.osmocom.org/q/topic:jenkins-no-manuals-dep

The build verification is failing, because this depends on the other patches from here (=> these need to be reviewed before I can continue):
https://gerrit.osmocom.org/q/topic:no-path-no-manuals-build

#8 Updated by osmith about 1 month ago

  • % Done changed from 70 to 80

#9 Updated by osmith about 1 month ago

  • Checklist item remove workaround for 'osmo-build-dep.sh osmo-gsm-manuals' again set to Done
  • % Done changed from 80 to 90
Remaining patches to be merged:

#10 Updated by osmith about 1 month ago

  • Status changed from In Progress to Resolved
  • % Done changed from 90 to 100

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)