Feature #4912
closedmake osmo-gsm-manuals part of the docker images
100%
Description
I don't think there is a lot be gained by re-building osmo-gsm-manuals all the time (via osmo-build-dep.sh osmo-gsm-manuals) from virtually every one of our build jobs. - particularly as that will do a 'make check" and hence build test user manuals every time.
I would guess it made more sense to simply include osmo-gsm-manuals.git into the build container. This way it is always pre-installed without having to explicitly install it.
Checklist
- interim measure: workaround for 'osmo-build-dep.sh osmo-gsm-manuals' to only clone, not build
- clone osmo-gsm-manuals in the docker image and on build slaves (for osmo-trx,bts which can't build in docker)
- add job to trigger update-osmo-ci-on-slaves when pushing to osmo-gsm-manuals.git, so the build slaves and docker images always have the latest version of osmo-gsm-manuals
- update OSMO_GSM_MANUALS_DIR
- remove 'osmo-build-dep.sh osmo-gsm-manuals' from contrib/jenkins.sh of all projects
- remove workaround for 'osmo-build-dep.sh osmo-gsm-manuals' again
Updated by osmith about 3 years ago
- % Done changed from 0 to 90
Updated by osmith about 3 years ago
- Checklist item interim measure: workaround for 'osmo-build-dep.sh osmo-gsm-manuals' to only clone, not build added
- Checklist item clone osmo-gsm-manuals in the docker image and on build slaves (for osmo-trx,bts which can't build in docker) added
- Checklist item add job to trigger update-osmo-ci-on-slaves when pushing to osmo-gsm-manuals.git, so the build slaves and docker images always have the latest version of osmo-gsm-manuals added
- Checklist item update OSMO_GSM_MANUALS_DIR added
- Checklist item remove 'osmo-build-dep.sh osmo-gsm-manuals' from contrib/jenkins.sh of all projects added
- Checklist item remove workaround for 'osmo-build-dep.sh osmo-gsm-manuals' again added
- % Done changed from 90 to 70
Setting the status back to 70%, as the initial patch is just a temporary solution (see review). I've updated the checklist, and I'm pretty far with unchecked tasks already, but I'm testing the changes some more before pushing the patches to gerrit.
Updated by osmith about 3 years ago
- https://gerrit.osmocom.org/c/osmo-e1-hardware/+/22125
- https://gerrit.osmocom.org/c/osmo-e1-hardware/+/22126
- https://gerrit.osmocom.org/c/osmo-e1-hardware/+/22127
EDIT: see #4943
Updated by osmith about 3 years ago
- Checklist item clone osmo-gsm-manuals in the docker image and on build slaves (for osmo-trx,bts which can't build in docker) set to Done
- Checklist item add job to trigger update-osmo-ci-on-slaves when pushing to osmo-gsm-manuals.git, so the build slaves and docker images always have the latest version of osmo-gsm-manuals set to Done
- Checklist item update OSMO_GSM_MANUALS_DIR set to Done
Updated by osmith about 3 years ago
More patches submitted, topic for both this issue and #4911:
https://gerrit.osmocom.org/q/topic:no-path-no-manuals-build
Updated by osmith about 3 years ago
- Checklist item remove 'osmo-build-dep.sh osmo-gsm-manuals' from contrib/jenkins.sh of all projects set to Done
remove 'osmo-build-dep.sh osmo-gsm-manuals' from contrib/jenkins.sh of all projects
Done for all the projects I had checked out (if I missed one, I'll add it as soon as it fails on jenkins):
https://gerrit.osmocom.org/q/topic:jenkins-no-manuals-dep
The build verification is failing, because this depends on the other patches from here (=> these need to be reviewed before I can continue):
https://gerrit.osmocom.org/q/topic:no-path-no-manuals-build
Updated by osmith about 3 years ago
- Checklist item remove workaround for 'osmo-build-dep.sh osmo-gsm-manuals' again set to Done
- % Done changed from 80 to 90
- https://gerrit.osmocom.org/q/topic:jenkins-no-manuals-dep (remove
osmo-build-dep.sh osmo-gsm-manuals
calls) - https://gerrit.osmocom.org/c/osmo-ci/+/22158
Updated by osmith about 3 years ago
- Status changed from In Progress to Resolved
- % Done changed from 90 to 100