Project

General

Profile

Feature #5042

Get rid of unnedeed quirks to have ttcn3 tests pass against older "latest" releases

Added by pespin 3 months ago. Updated 2 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
-
Start date:
02/23/2021
Due date:
% Done:

100%

Spec Reference:

Description

Today a cascade-release of all osmocom CNI projects are being released.

As a result, "latest" ttcn3 test config in docker-playground.git need to be modified to drop the changes being made to have them passed against older releases (since the release is now what user to be master).

This has been done here:
https://gerrit.osmocom.org/c/docker-playground/+/23053 Remove test backward compatibility with older osmo-* versions

However, we need to go around all those TTCN3 module parameters in osmo-ttcn3-hacks.git being dropped in patch above, and see which ones we can get rid of since they are not needed anymore.

Associated revisions

Revision c63a131a (diff)
Added by pespin 3 months ago

Remove test backward compatibility with older osmo-* versions

These changes are no longer needed since master versions of whole CNI
have been recently released.

Related: OS#5042
Change-Id: I6f491b58d4576b22c8ff3ab56a7b9e17163a8739

Revision 4858184b (diff)
Added by pespin 3 months ago

StatsD_Checker: Enable by default

It was previously disabled by default in order to avoid test breakage
with older versions of osmocom projects not supporting them. Since we
just did a new release, all -latest contian now master which should work
fine.

Don't remove the moduleparam yet in order to avoid breakage with some
cfg files in docker-playground.git still setting it to true.

Related: OS#5042
Change-Id: I4e2049c109986906d3c985ca2282174b1abff581

Revision bd79c36e (diff)
Added by pespin 3 months ago

Get rid of uneeded param StatsD_Checker.mp_enable_stats

This param is currently set to true by default and will be removed soon.

Related: OS#5042
Depends: osmo-ttcn3-hacks.git Change-Id I4e2049c109986906d3c985ca2282174b1abff581
Change-Id: I3c7e7dc985a339d884dc388b33bf8a6ec986c5b7

Revision a0026cd7 (diff)
Added by pespin 3 months ago

ttcn3-bsc: Get rid of uneeded param BSC_Tests.mp_media_mgw_offer_ipv6

This param is true by default and there's no one setting it to false
anymore (and soon will be removed).

Related: OS#5042
Change-Id: I1780320c69ec4a9f086677fd4884dec674f8332e

Revision 9d788c90 (diff)
Added by pespin 3 months ago

bsc: Get rid of module param mp_media_mgw_offer_ipv6

This param is not needed anymore sincenew releases used in -latest don't
need to disable it.
Let's keep the possibility to change behavior from within test and leave
v6 enabled by default as it used to be.

Related: OS#5042
Change-Id: Ic693885dd3d4259dc6ce80643d25c7d432148d3d

Revision 6ef96e49 (diff)
Added by pespin 3 months ago

bts-test: Drop uneeded module param RSL_Emulation.mp_rslem_patch_ipa_cid

Since we updated -latest to new releases, this param is never set to
true anymore. Furtermore, it will be dropped soon completely.

Related: OS#5042
Depends: osmo-ttcn3-hacks.git Change-Id I39e9c1986ea682d54dcb22b31798ca91f1677949
Change-Id: I4bda577f1ed6964a2114df1aba366177998f0854

Revision f0b7d4f3 (diff)
Added by pespin 3 months ago

RSL_Emulation: Get rid of module param mp_rslem_patch_ipa_cid

This param is not needed anymore since new releases used in -latest don't
need to disable it.

Change-Id: I39e9c1986ea682d54dcb22b31798ca91f1677949
Related: OS#5042

Revision 174fac25 (diff)
Added by pespin 3 months ago

msc: Get rid of several uneeded module params

These params are not needed anymore since new releases used in -latest don't
need to disable it.

Change-Id: I16575ae4f615bf7c42d5921917003007ba4872a0
Related: OS#5042

Revision c3344ea3 (diff)
Added by pespin 3 months ago

sip: Don't need to set default value of MNNC version

The module param default value is already v7, no need to set it.

Change-Id: Idb075f78e1de5a74a442f85dcf2c9e900e5511cb
Related: OS#5042

Revision 0055a29e (diff)
Added by pespin 3 months ago

hlr: Get rid of module param mp_hlr_supports_dgsm

This param is not needed anymore since new releases used in -latest don't
need to disable it.

Change-Id: I484267c169646310564bd6d9cd13a196b61400e4
Related: OS#5042

Revision 06b256e3 (diff)
Added by pespin 3 months ago

ttcn3-msc: Drop uneeded module params

Since -latest was updated to newer releases, there's no need to change
the values of these params. Furthermore, they will be completely dropped soon.

Change-Id: I6121b435c5b984eab64d953e9d3f26eecc0e7bc5
Related: OS#5042

Revision 5a31e0ad (diff)
Added by pespin 3 months ago

ttcn3-sip: Drop uneeded module param MNCC_Emulation.mp_mncc_version

Since -latest was updated to newer releases, this param is never set to
changed anymore, so there's no need to set it here explicitly.

Change-Id: Ia9d6b7f383d6532f8f2da381e80f98af82a98e74
Related: OS#5042

Revision 9688dc9a (diff)
Added by pespin 2 months ago

bts: Add new stats to detect TBF allocation failure reasons

This is specially useful to detect for instance if a cell is handling
too many users, ending up in TFI or USF exhaustions. This information
can be later in the future used to tune TBF allocation algorithm behavior
(either manually/statially through config file, or
automatically/dynamically in code based on some thresholds).

Related: OS#5042
Change-Id: I5402e937ff8d800684655e500ef8e5c867141dc3

History

#1 Updated by pespin 3 months ago

  • Status changed from New to Feedback
  • Assignee set to pespin
  • % Done changed from 0 to 90

Patches pushed to gerrit, I'll submit them this afternoon.

#2 Updated by pespin 2 months ago

  • Status changed from Feedback to Resolved
  • % Done changed from 90 to 100

Merged, closing.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)